Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Findings and notes do not "follow" code. #15

Open
paul-uz opened this issue Mar 22, 2024 · 3 comments
Open

Findings and notes do not "follow" code. #15

paul-uz opened this issue Mar 22, 2024 · 3 comments
Labels

Comments

@paul-uz
Copy link

paul-uz commented Mar 22, 2024

I added a finding and a note to some code, but afterwards, I modified the code, adding some new functions. The finding and note keep their original line numbers, meaning they no longer relate to the original code I highlighted.

@fcasal
Copy link
Collaborator

fcasal commented Mar 22, 2024

Hello @paul-uz,
what you describe is known behavior as weAudit is unaware of the contents of files, and only knows about line regions in files.

You probably have noticed that, despite this, the code region will move when you write code around a highlighted code region, giving the impression that it is computing the correct regions. However, there is no way of tracking these events to correctly update the code region (see e.g., microsoft/vscode#48364). There seem to be some cases where people manually track and compute these changes, but we decided not to try implement this feature for the time being.

@paul-uz
Copy link
Author

paul-uz commented Mar 22, 2024

Could you at least make it easier to change the line numbers in the UI?

If I could select a note and drag it up and down, and expand or shrink it, without the UI, that would at least be acceptable for now.

@n0kto
Copy link

n0kto commented May 18, 2024

Completly agree on this one! If this is not possible to keep track of new lines, a UI drag and drop could be a useful mitigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants