Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track "Update operations commit-reveal chain may lead to an unresolvable DID" #344

Open
BenjaminMoe opened this issue Jan 13, 2022 · 0 comments

Comments

@BenjaminMoe
Copy link
Contributor

BenjaminMoe commented Jan 13, 2022

decentralized-identity/sidetree#1169

Quote:  @shakreiner
The current iterations over Update operation using the commit-reveal chain may lead to an infinite loop when trying to resolve a DID.
The thing that can cause this state is having a DID with 2 Update operations, where the second operation commits to the first one again.
This situation should not be allowed based on the specification (updateCommitment must be a new commitment in every operation), but the code doesn't seem to enforce that.

As a sidetree implementation, we need to make sure that this is working in-code and not just in-theory. We need to add a unit test that tracks multiple-commits to make sure it doesn't result in an unsolvable did, and formulate a response depending on the unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant