forked from Jonathan-Rosenberg/oasdiff
-
Notifications
You must be signed in to change notification settings - Fork 1
/
check-response-pattern-added-or-changed_test.go
87 lines (73 loc) · 3.46 KB
/
check-response-pattern-added-or-changed_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
package checker_test
import (
"testing"
"github.com/stretchr/testify/require"
"github.com/treeverse/oasdiff/checker"
"github.com/treeverse/oasdiff/diff"
)
// CL: changing response property pattern
func TestResponsePropertyPatternChanged(t *testing.T) {
s1, err := open("../data/checker/response_pattern_added_or_changed_base.yaml")
require.NoError(t, err)
s2, err := open("../data/checker/response_pattern_added_or_changed_revision.yaml")
require.NoError(t, err)
s2.Spec.Components.Schemas["GroupView"].Value.Properties["data"].Value.Properties["name"].Value.WriteOnly = true
d, osm, err := diff.GetWithOperationsSourcesMap(getConfig(), s1, s2)
require.NoError(t, err)
errs := checker.CheckBackwardCompatibilityUntilLevel(singleCheckConfig(checker.ResponsePatternAddedOrChangedCheck), d, osm, checker.INFO)
require.Len(t, errs, 1)
require.Equal(t, checker.ApiChange{
Id: "response-property-pattern-changed",
Text: "the 'data/created' response's property pattern was changed from '^[a-z]+$' to '^(?:([a-z]+-)*([a-z]+)?)$' for the status '200'",
Comment: "",
Level: checker.INFO,
Operation: "POST",
Path: "/api/v1.0/groups",
Source: "../data/checker/response_pattern_added_or_changed_revision.yaml",
OperationId: "createOneGroup",
}, errs[0])
}
// CL: adding response property pattern
func TestResponsePropertyPatternAdded(t *testing.T) {
s1, err := open("../data/checker/response_pattern_added_or_changed_base.yaml")
require.NoError(t, err)
s2, err := open("../data/checker/response_pattern_added_or_changed_base.yaml")
require.NoError(t, err)
s1.Spec.Components.Schemas["GroupView"].Value.Properties["data"].Value.Properties["created"].Value.Pattern = ""
d, osm, err := diff.GetWithOperationsSourcesMap(getConfig(), s1, s2)
require.NoError(t, err)
errs := checker.CheckBackwardCompatibilityUntilLevel(singleCheckConfig(checker.ResponsePatternAddedOrChangedCheck), d, osm, checker.INFO)
require.Len(t, errs, 1)
require.Equal(t, checker.ApiChange{
Id: "response-property-pattern-added",
Text: "the 'data/created' response's property pattern '^[a-z]+$' was added for the status '200'",
Comment: "",
Level: checker.INFO,
Operation: "POST",
Path: "/api/v1.0/groups",
Source: "../data/checker/response_pattern_added_or_changed_base.yaml",
OperationId: "createOneGroup",
}, errs[0])
}
// CL: removing response property pattern
func TestResponsePropertyPatternRemoved(t *testing.T) {
s1, err := open("../data/checker/response_pattern_added_or_changed_base.yaml")
require.NoError(t, err)
s2, err := open("../data/checker/response_pattern_added_or_changed_base.yaml")
require.NoError(t, err)
s2.Spec.Components.Schemas["GroupView"].Value.Properties["data"].Value.Properties["created"].Value.Pattern = ""
d, osm, err := diff.GetWithOperationsSourcesMap(getConfig(), s1, s2)
require.NoError(t, err)
errs := checker.CheckBackwardCompatibilityUntilLevel(singleCheckConfig(checker.ResponsePatternAddedOrChangedCheck), d, osm, checker.INFO)
require.Len(t, errs, 1)
require.Equal(t, checker.ApiChange{
Id: "response-property-pattern-removed",
Text: "the 'data/created' response's property pattern '^[a-z]+$' was removed for the status '200'",
Comment: "",
Level: checker.INFO,
Operation: "POST",
Path: "/api/v1.0/groups",
Source: "../data/checker/response_pattern_added_or_changed_base.yaml",
OperationId: "createOneGroup",
}, errs[0])
}