The error message displayed when compiling a template, doesn't contain location / file information #318
Comments
|
Thanks for opening this issue and bringing this to our attention! This behavior is odd. The gem doesn't do anything with the The way we handle inter process communication between Outside of that, we don't have any logic around including / excluding error messages or stack traces. TL;DR: What version of Ember CLI are you using? What version of the gem are you using? What version of the addon are you using? On the surface, this sounds like a bug in the way EmberCLI writes errors. |
|
Thanks for a speedy reply, sorry for not including this information in the first place: gem: most recent version from github, from Gemfile.lock When doing: the generated errors.txt includes the file information, here is the output: |
|
Bad news: Unfortunately, it doesn't. This also includes deprecations, so the first backtrace will not necessary be the actual ERROR. |
|
@seanpdoyle How do you want to approach filtering out deprecations from the error file ?
|
Related to [tricknotes/ember-cli-rails#318][#318]. The `ember-cli-rails` gem redirects the `ember build --watch` process' `STDERR` to the same file the addon previously wrote two. These two processes would contend over writing to the file, and flip-flop, clobbering the others' output. To correct this, we'll defer error logging to the gem (and ultimately, `ember-cli`'s writing correctly to `STDERR`). [#318]: tricknotes/ember-cli-rails#318
|
Unfortunately, When the gem executes the To correct this, we can change how the addon behaves. Unfortunately, this fix is blocked by EmberCLI writing Once a fix for that improper behavior lands, we can merge rondale-sc/ember-cli-rails-addon#24 |
|
@kozak bad news: there isn't a good approach to prevent writing DEPRECATION warnings to good news is that @rwjblue has written https://github.com/rwjblue/ember-cli-template-lint, which delays throwing deprecation warnings, pushing them out of build tools and into the browser. Would you mind adding that addon in combination with rondale-sc/ember-cli-rails-addon#24? If that works for you, I could merge and release, documenting the new dependency. |
|
Tangentially related, I received:
Which is a warning of a stupidly long template, but causes the rails server to throw an error even though the build was technically successful. This is with rondale-sc/ember-cli-rails-addon#24 |
|
@seanpdoyle Sorry for getting back so late. Your suggested setup works fine and displays the correct error message! |
|
@kayakyakr addressed in babel/babel#3156 |
Related to [tricknotes/ember-cli-rails#318][#318]. The `ember-cli-rails` gem redirects the `ember build --watch` process' `STDERR` to the same file the addon previously wrote two. These two processes would contend over writing to the file, and flip-flop, clobbering the others' output. To correct this, we'll defer error logging to the gem (and ultimately, `ember-cli`'s writing correctly to `STDERR`). [#318]: tricknotes/ember-cli-rails#318
|
@kayakyakr according to to maintainer of Babel:
|
|
I've stopped receiving the error, though, so I can't dig deeper right now... The worst thing is that it's coming from a handlebars template that's around 10k in size. A 250 line, 8000 character template explodes into a 99,000 character js file. Yikes. |
I had an error in a handlebars template (there is a href="#" and also a binding to href):
The error I got, didn't include the file information that is normally included in
ember buildThis is what was displayed:
When I run
ember buildI get a huge stack trace (which also includes deprecation information) and the file name:The text was updated successfully, but these errors were encountered: