Releasing 2.6

[DanVanAtta]

Discussion thread to discuss & coordinate 2.6 release

[DanVanAtta]

Problem - Blocking - error joining bot

Using a latest 2.6, I joined a bot & got this error:

InvalidClassException: games.strategy.triplea.delegate.battle.steps.change.RemoveUnprotectedUnitsGeneral; local class incompatible: stream classdesc serialVersionUID = -2275572358057628023, local class serialVersionUID = 3657854923401656587

[DanVanAtta]

This was with revision 2.6.14681, with the latest master @ e1217a3 (latest commit on Apr 9), when connecting to bots, I get:

java.io.IOException: java.io.IOException: Socket closed
	at games.strategy.net.ClientMessenger.<init>(ClientMessenger.java:121)
	at games.strategy.net.ClientMessengerFactory.newClientMessenger(ClientMessengerFactory.java:27)
	at games.strategy.engine.framework.startup.mc.ClientModel.createClientMessenger(ClientModel.java:232)
	at games.strategy.engine.framework.startup.ui.panels.main.HeadedServerSetupModel.showClient(HeadedServerSetupModel.java:107)
	at org.triplea.game.client.HeadedGameRunner.showMainFrame(HeadedGameRunner.java:170)
	at org.triplea.game.client.HeadedGameRunner.lambda$start$6(HeadedGameRunner.java:147)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.io.IOException: Socket closed
	at games.strategy.net.nio.SocketReadData.read(SocketReadData.java:48)
	at games.strategy.net.nio.NioReader.loop(NioReader.java:97)
	... 1 common frames omitted

[DanVanAtta]

It was maybe a bad bot... Trying with another bot - no issues!

[DanVanAtta]

History & Status of Release Blockers

Except for any blockers identified in this discussion, we should be good to go on the game client.

In order to release 2.6 we needed:

• bot networking compatibility restored
• map download working
• latest version fetch working
• lobby message working

All 4 items are now resolved. @asvitkine fixed the bot networking incompatibility as well as reverted back the map download to use the old static file. I recently resolved the last two items & reverted the latest version fetch & did a partial revert & small fix for the lobby message.

We do not need to deploy the lobby. It's actually the 2.4 lobby that is still running and servicing the 2.5 players.
The 2.6 client should be is compatible with the 2.4 lobby.

[DanVanAtta]

We're back to having no known issues.

[DanVanAtta]

2.6 game client now connects to the 2.4 lobby by default

I updated this config today (Apr 10)

admin@prod:~$ sudo vi /etc/nginx/sites-enabled/lobby.conf 
  (updated 2.6   to go to port 8080)

admin@prod:~$ head -5 /etc/nginx/sites-enabled/lobby.conf 
map $http_Triplea_Version $lobby_port {
   default  "8080";
   2.5  "8080";
   2.6  "8080";
}

admin@prod:~$ sudo systemctl reload nginx