Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking to libssl, libcrypto and libz breaks manylinux compatibility according to PEP-513 #752

Open
vsbogd opened this issue Jul 25, 2024 · 2 comments

Comments

@vsbogd
Copy link
Collaborator

vsbogd commented Jul 25, 2024

Reading PyO3 extension-module documentation mentioned in #432 I have found link to the PEP-513 which says that manylinux1 compatible extensions should not be dynamically linked to the shared libraries out of the provided list. Thus libssl, libcrypro and libz which are used by Git feature breaks compatibility.

@vsbogd vsbogd added the python label Jul 25, 2024
@vsbogd vsbogd added the build label Aug 1, 2024
@luketpeterson
Copy link
Contributor

Hmmm. That's annoying.

It appears that https://pypi.org/project/GitPython/ uses gitoxide-core through https://github.com/Byron/gitoxide/tree/main

So perhaps we can get rid of the libgit2 downstream dependencies by moving to gitoxide-core. I can try that out.

@vsbogd
Copy link
Collaborator Author

vsbogd commented Aug 1, 2024

It is worth to mention #725 is also related. Dynamic linkage of the system libraries in MacOSX leads to the packages which are incompatible with old MacOSX version and checkers used by cibuildwheel finds this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants