Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132681 / 24.10.2 / Reload iscsitarget on iscsi.auth.delete (by bmeagherix) #15007

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 932bfbc35d9c4efce59f01f938c7e04a8943329f

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 510930b97aaadde14979666542ec75aee9f5b689

Was doing reload on iscsi.auth.create and iscsi.auth.update, but not on iscsi.auth.delete. Rectify.

Original PR: #15006
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132681

@yocalebo
Copy link
Contributor

This is safe enough to back port to 24.10.1 and we're still early enough in QE process to get this in.

@yocalebo yocalebo marked this pull request as ready for review November 21, 2024 18:18
@yocalebo yocalebo merged commit fe1c118 into stable/electriceel Nov 21, 2024
1 of 2 checks passed
@yocalebo yocalebo deleted the NAS-132681-24.10.2 branch November 21, 2024 18:18
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants