NAS-132676 / 25.04 / Only redact secrets when the method return value is passed to the user #15042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
time 4:00 |
bugclerk
changed the title
themylogin
force-pushed
the
NAS-132676
branch
2 times, most recently
from
a6c4fb3
to
ef9e28b
Compare
themylogin
force-pushed
the
NAS-132676
branch
from
ef9e28b
to
1b1b658
Compare
|
time 2:00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
call_with_auditwas redacting the secrets. This caused issues when its result was passed to the API versions conversion code (as it was trying to validateport="********"as integer).