Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
ahrav committed Nov 7, 2024
1 parent 8740bc6 commit 627ece0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
4 changes: 0 additions & 4 deletions pkg/sources/s3/progress_tracker.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,6 @@ func (p *ProgressTracker) GetResumePoint(ctx context.Context) (ResumeInfo, error
// Complete marks the entire scanning operation as finished and clears the resume state.
// This should only be called once all scanning operations are complete.
func (p *ProgressTracker) Complete(_ context.Context, message string) error {
if !p.enabled {
return nil
}

// Preserve existing progress counters while clearing resume state.
p.progress.SetProgressComplete(
int(p.progress.SectionsCompleted),
Expand Down
6 changes: 3 additions & 3 deletions pkg/sources/s3/progress_tracker_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ func TestComplete(t *testing.T) {
}{
sectionsCompleted: 50,
sectionsRemaining: 100,
resumeInfo: `{"CurrentBucket":"test-bucket","StartAfter":"some-key"}`,
resumeInfo: "",
message: "Should not change",
},
completeMessage: "Completed",
Expand All @@ -589,8 +589,8 @@ func TestComplete(t *testing.T) {
}{
sectionsCompleted: 50,
sectionsRemaining: 100,
resumeInfo: `{"CurrentBucket":"test-bucket","StartAfter":"some-key"}`,
message: "Should not change",
resumeInfo: "",
message: "Completed",
},
},
{
Expand Down

0 comments on commit 627ece0

Please sign in to comment.