Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ruff parsing for source files with syntax errors #914

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fix ruff parsing for source files with syntax errors #914

merged 3 commits into from
Nov 12, 2024

Conversation

det
Copy link
Contributor

@det det commented Nov 12, 2024

Ruff now reports syntax errors as a diagnostic with a null code.

@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 12, 2024 •
edited
Loading

⏱️ 2h 10m total CI duration on this PR
Job Cumulative Duration Recent Runs
Windows Linter Tests 1h 42m ⬜ ⬜ 🟥 
Linter Tests ubuntu-latest 12m 🟥 🟥 🟩 
Linter Tests macOS 8m ⬜ ⬜ 🟩 
CodeQL-Build 5m 🟩 🟩 🟩 
Trunk Check runner [linux] 2m 🟩 🟩 🟩 
Repo Tests / Plugin Tests 2m 🟩 🟩 🟩 
Aggregate Test Results 16s 🟥 🟥 🟩 
Detect changed files 15s 🟩 🟩 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@det det requested a review from TylerJang27 November 12, 2024 22:24
TylerJang27
TylerJang27 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trunk-staging-io Trunk-Staging.io
Copy link

trunk-staging-io bot commented Nov 12, 2024 •
edited
Loading

12 tests were run on ae047b87. ✅ 12 Passed. View Full Report ↗︎

settings

@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 12, 2024 •
edited
Loading

12 tests were run on ae047b87. ✅ 12 Passed. View Full Report ↗︎

settings

@det det merged commit c45aa94 into main Nov 12, 2024
13 of 14 checks passed
@det det deleted the det/ruff_syntax branch November 12, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerJang27 TylerJang27 TylerJang27 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@det @TylerJang27