Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip standard/fido2/pin/ tests if device does not support clientPin #17

Open
andrewkozlik opened this issue Oct 1, 2019 · 0 comments
Open

Skip standard/fido2/pin/ tests if device does not support clientPin #17

andrewkozlik opened this issue Oct 1, 2019 · 0 comments

Comments

@andrewkozlik
Copy link
Contributor

The tests in tests/standard/fido2/pin/ assume that the authenticator supports clientPin. Authenticators which verify the user directly on the device, such as Trezor, do not support clientPin, so they will fail these tests. The tests should be run only if the clientPin option is present in the authenticatorGetInfo response.
I am not sure how to implement this, because apparently you can't do @pytest.mark.skipif() based upon the info fixture.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewkozlik