SPM conflict SwiftProtobuf

[nerzh]

Sorry for my english

Describe the bug
Google FireBase has SwiftProtobuf as a dependency:
.package(
name: "SwiftProtobuf",
url: "https://github.com/apple/swift-protobuf.git",
"1.15.0" ..< "2.0.0"
),

but wallet-core has SwiftProtobuf as a dependency too:

.binaryTarget(
name: "SwiftProtobuf",
url: "https://github.com/trustwallet/wallet-core/releases/download/2.6.36/SwiftProtobuf.xcframework.zip",
checksum: "40518a795e841bbd2c7e1f7019357b8e09b321a9c1ea264b0819f85575ac04c2"
)

Because you have a binary target, this causes a name conflict with SwiftProtobuf.

Please, tell me what to do with it, thanks

To Reproduce
Steps to reproduce the behavior:

1. add Firebase to ios project
2. add wallet-core to the project

Expected behavior
No conflict with SwiftProtobuf

[hewigovens]

Yes, because wallet core is a binary framework, it needs SwiftProtobuf as a binary framework too. The workaround is: download wallet core xcframework from github release and manually add it to your project.

[oliveratkinson-bc]

@hewigovens This doesn't really work around the issue since Firebase includes swift-protobuf and statically links the binary to the resulting app bundle, which means the WalletCore.framework isn't able to locate it since it has an explicit rpath to @rpath/SwiftProtobuf.framework/SwiftProtobuf

To solve this, we would likely need to allow compilation of wallet-core via SPM rather than as a binary framework so that it can include the same versioned swift-protobuf dependency

[nerzh]

@oliveratkinson-bc it would be great

[hewigovens]

@oliveratkinson-bc I agree with you, but wallet core needs special build steps and SPM seems limited (unlike CocoaPods, easy to add scripts) cc @Milerius

[oliveratkinson-bc]

It's worth noting that SPM has got some upgrades as of 5.7, one of which is "Package Manager Plugins" that should aid in the ability to script elements of the build pipeline

[nerzh]

this article says it's available already in 5.6

https://theswiftdev.com/beginners-guide-to-swift-package-manager-command-plugins

[oliveratkinson-bc]

@nerzh yes, but it had issues, became usable in 5.7

[EvgenV]

Hi @oliveratkinson-bc !
Have you managed to solve this problem? Could you please share with workaround?

[nerzh]

🙄

[MaksymVereshchaka]

@nerzh @oliveratkinson-bc @EvgenV
I would like to know if there are any results?

[oliveratkinson-bc]

@MaksymVereshchaka I have not found a workaround for this issue

[nerzh]

no, I don’t understand why the package was called that at all. You could also call the wallet not Trustwallet but Googlewallet, why not ? 😀

[tysonwil]

@nerzh @oliveratkinson-bc were you ever able to find a workaround to this?

[dinhnhat0401]

@tysonwil @nerzh @oliveratkinson-bc take a look at this PR. Please give a thumb up if this fix your issue.
#3599