Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust]: Extend codegen-v2 capabilities #3570

Merged
merged 21 commits into from
Nov 24, 2023
Merged

[Rust]: Extend codegen-v2 capabilities #3570

merged 21 commits into from
Nov 24, 2023

Conversation

satoshiotomakan
Copy link
Collaborator

@satoshiotomakan satoshiotomakan commented Nov 23, 2023 •
edited
Loading

Description

  • Generate protobuf file on new-blockchain <coinid> command.
  • Generate C++ Entry.cpp file as well to make it straightforward for the external developers.
  • Generate C++ integration tests within tests/<chainid> dir.
  • Generate Rust Signer and Address structures on cargo run -- new-blockchain.
  • Configure codegen-v1 tool to generate only Kotlin and Swift tests.
  • Generate Kotlin, Swift integration tests.
  • Add cargo run -- newevmchain command.

How to test

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@satoshiotomakan
[Rust]: Small refactoring
0b9df50
@satoshiotomakan
[Rust]: Add TemplateGenerator
8295fa8 
* Add new blockchain crate templates
@satoshiotomakan
[Rust]: Add new blockchain integration tests templates
68c2c12
@satoshiotomakan
[Rust]: Add new blockchain to test_coin_address_derivation
7ff16cf
@satoshiotomakan
[C++]: Add cpp::new_blockchain
569ab38 
* Add C++ Entry.h template
@satoshiotomakan
[C++]: Fix cpp::new_blockchain
12b53f4
@satoshiotomakan
[C++]: Add TWCoinType, TWBlockchain enum generating
b2c0746
@satoshiotomakan
[C++]: Add Blockchain entry to the Coin.cpp dispatcher
d523af4
@satoshiotomakan
[Codegen]: Some improvements
fdcc7c5
@satoshiotomakan
[Codegen]: Revert coin_skeleton_gen.rb
510ad34
@satoshiotomakan
[Codegen]: Generate Blockchain.proto file
1cca1b1
@satoshiotomakan
[Codegen]: Generate TWCoinTypeTests.cppp file
c177cd0
@satoshiotomakan
[Codegen]: Generate TWAnySignerTests.cpp, TWAnyAddressTests.cpp files
05368fb
@satoshiotomakan
[Codegen]: Fix Protobuf
b6831b5
@satoshiotomakan
[Codegen]: Refactor codegen-v1 to allow to generate mobile tests only
d9a9694
@satoshiotomakan
[Codegen]: Generate CoinAddressDerivationTests.cpp cases
c5795bf
@satoshiotomakan
[Codegen]: Add new-evmchain cmd
9ee8708
@satoshiotomakan
[Codegen]: Refactor C++ code generators
ec4197c
@satoshiotomakan
[Codegen]: Refactor Rust generators, fix sorting error
937d12a
@satoshiotomakan
[Codegen]: Run codegen-v2 new-blockchain-rust iotex on Rust CI pipeline
71e9460
@satoshiotomakan satoshiotomakan marked this pull request as ready for review November 24, 2023 11:35
lamafab
lamafab approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@lamafab lamafab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👌

@satoshiotomakan satoshiotomakan merged commit 6ef3eb5 into master Nov 24, 2023
13 checks passed
@satoshiotomakan satoshiotomakan deleted the s/cpp-codegen branch November 24, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamafab lamafab lamafab approved these changes

@Milerius Milerius Awaiting requested review from Milerius Milerius is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satoshiotomakan @lamafab