Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ownCloud incorrectly identified as page to get highlighted #65

Open
eraaijmakers opened this issue Jul 13, 2015 · 4 comments
Open

ownCloud incorrectly identified as page to get highlighted #65

eraaijmakers opened this issue Jul 13, 2015 · 4 comments

Comments

@eraaijmakers
Copy link

ownCloud is a private cloud storage system. I noticed an issue when clicking on a download link that I could link to Sight. Look at owncloud/core#17520 for the issue report at the ownCloud github page.

Is there any way to exclude ownCloud from getting parsed by Sight?

@tsenart
Copy link
Owner

tsenart commented Jul 13, 2015

Thanks for reporting this. I've seen this happening to me too. I'll try to work on it sometime soon.

@ratio187
Copy link

ratio187 commented Mar 6, 2017

Any update on this? Every time I download a torrent file the font on the page gets by Sight. Requires me to reload the page after every download so I can get the page back to normal. Thanks!

@tsenart
Copy link
Owner

tsenart commented Mar 7, 2017

I don't have time to work on a solution. Open to good contributions though!

@ratio187
Copy link

ratio187 commented Mar 7, 2017

@tsenart I had a look and I can see why it is happening but I'm not sure how to fix it since I have zero experience in Chrome Extension development. In case you haven't already figured out why, I'll leave my findings here in case it might help you or somebody else resolve the issue in the future.

It happens specifically when you have a download link that uses GET parameters to retrieve the file download URL. For example: http://website.com/download.php?id=xyz

In the example the extension thinks you're trying to look at a PHP file so the styles get inserted into the page but the extension doesn't take into account that the request is routed to the location of a file to download. Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants