Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require v prefix on Gleam versions #53

Open
lpil opened this issue Nov 25, 2024 · 2 comments
Open

Do not require v prefix on Gleam versions #53

lpil opened this issue Nov 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@lpil
Copy link

lpil commented Nov 25, 2024

# beamup install gleam 1.6.2
Created a default config at "/root/.config/beamup/config.toml"
Downloading and installing Gleam for release=1.6.2 id=1.6.2
Error: Failed fetching Github release 1.6.2 from gleam-lang/gleam

Caused by:
   0: GitHub
   1: Not Found
      Documentation URL: https://docs.github.com/rest/releases/releases#get-a-release-by-tag-name

Location:
    src/github.rs:142:29
@tsloughter
Copy link
Owner

Yea, this was a bit of laziness as well as the thinking that accepting a "version" implied more verification than beamup was going to do. So I left it as taking a release name.

Probably for the best if after a Not Found is return that it first makes an attempt by adding v.

@tsloughter
Copy link
Owner

I can still be lazy and even check for vOTP-missing, hehe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants