Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questions about Example_06_DataStream_Join #4

Open
liuml07 opened this issue Apr 18, 2022 · 1 comment
Open

Questions about Example_06_DataStream_Join #4

liuml07 opened this issue Apr 18, 2022 · 1 comment

Comments

@liuml07
Copy link

liuml07 commented Apr 18, 2022

  1. The processElement1() method should check if (txs.hasNext())? See code
  2. Should we add timer (clear state, log warning etc) in the two processElement methods, in case the other stream is never ready?
@twalthr
Copy link
Owner

twalthr commented Apr 19, 2022

  1. This is indeed a bug. I will fix it in my next iteration. Thanks for pointing it out!
  2. Yes, there is more code required to make this production ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liuml07 @twalthr