Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linear-base has a streaming-style Stream type. Should it have a streaming-bytestring style ByteStream? #435

Open
endgame opened this issue Jan 7, 2023 · 1 comment

Comments

@endgame
Copy link
Contributor

endgame commented Jan 7, 2023

Is your feature request related to a problem? Please describe.
The streaming package has a corresponding streaming-bytestring package, with a specialised ByteStream m r type. Should linear-base adopt this convention also, and provide a linear ByteStream to parallel the linear streams it provides?

Describe the solution you'd like
A definite decision that yes, we'd like a linear ByteStream library (and would be open to a PR, even if there's no near-term plan for Tweag to build one); or no, you should be using Stream (Of ByteString).

@endgame endgame changed the title linear-base has a streaming-style Stream type. Should it have a streaming-style ByteStream? linear-base has a streaming-style Stream type. Should it have a streaming-bytestring style ByteStream? Jan 7, 2023
@aspiwack
Copy link
Member

Hi, sorry for the delay: I've been away, then catching up on the things that happened while I was away.

I'd take a ByteStream type, yes. I actually strongly believe this is the Right Way™ to do low-level IO. I don't have the bandwidth to participate, but I'll gladly take and review a PR. And advise if you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants