Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroller Pane value doesnt update when switching spectrum #54

Open
BirbIrl opened this issue Jul 8, 2023 · 5 comments
Open

Scroller Pane value doesnt update when switching spectrum #54

BirbIrl opened this issue Jul 8, 2023 · 5 comments
Assignees
Labels
bug Something isn't working low priority Something with low priority

Comments

@BirbIrl
Copy link

BirbIrl commented Jul 8, 2023

There is currently a bug with the slider that when enabling the negative spectrum for the scroll panel, you can't go from +X to -X without going to +Y then to -X. I.e: From 5 you can't go to -5, but you can go from 5 to -4, -6, -7 etc.

This is due to the fact that the slider seems to get confused where it really is. When selecting a positive value when the negative values are enabled, the slider after locking in the positive value, still loads in the negative slider's position every time you try and open the menu - instead of the positive slider right under.

1.19.2
1.5
Fabric

@BirbIrl BirbIrl added the bug Something isn't working label Jul 8, 2023
@BirbIrl
Copy link
Author

BirbIrl commented Jul 8, 2023

also, when you set the limit to a negative number it gets REALLY messed up, is the best way i can describe it. Just lock the panel if the limit is a negative number.
Also also when the number is really big (idk i just threw in a 9999999) it crashed my client when right clicking the ui so there should probably be a lock for that too-

@SammyForReal
Copy link
Collaborator

If I understood you right, then the described bugs inside the UI seems to be something outside of our powers of fixing this. This feature is from Create, so you might want to open this in the Fabricators-of-Create repository (Correct me if I misunderstood you)

Other than that, the desribed crashes or REALLY messed up behaviour seems to be something we didnt had in mind.
Thank you for taking the time with this, I will try to fix this quickly!

@BirbIrl
Copy link
Author

BirbIrl commented Jul 8, 2023

Yeah the negative number issue seems more of a create issue! I wasn't sure if the mod can interface with how negative numbers work.

@SammyForReal
Copy link
Collaborator

Oh the bug with switching the direction (aka minus spectrum) seems to be a bug on our side, sorry!

@SammyForReal
Copy link
Collaborator

Alright, that setLimit crash got fixed now. That thing with not applying when switching minus and non-minus spectrum however not. I will keep this in mind however (and keep this one open because of this)

@SammyForReal SammyForReal added the low priority Something with low priority label Jul 8, 2023
@SammyForReal SammyForReal changed the title Scroller pane slider bug Scroller Pane value doesnt update when switching spectrum Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority Something with low priority
Projects
None yet
Development

No branches or pull requests

2 participants