Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advancement loading error on startup #91

Open
tmvkrpxl0 opened this issue Apr 27, 2024 · 4 comments
Open

Advancement loading error on startup #91

tmvkrpxl0 opened this issue Apr 27, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@tmvkrpxl0
Copy link

Description
Insert a clear and concise description of what the bug is.
This error is printed on startup:

[06:19:57] [main/ERROR] [minecraft/ServerAdvancementManager]: Parsing error loading custom advancement cccbridge:place_animatronic: Failed to parse 'location' field
[06:19:57] [main/ERROR] [minecraft/ServerAdvancementManager]: Parsing error loading custom advancement cccbridge:place_redrouter: Failed to parse 'location' field

and I believe advancement is not working correctly due to this.

To Reproduce
Steps to reproduce the behavior:

  1. Install cccbridge
  2. Start world. Preferably on dedicated server as the output is more cleaner.
  3. Observe that error

Expected behavior
Insert a clear and concise description of what you expected to happen.
I expected advancement to word without issue.

Software (please complete the following information):

  • Minecraft Version 1.20.1
  • Mod Version 1.6.3
  • ModLoader: Forge 47.2.30
@tmvkrpxl0 tmvkrpxl0 added the bug Something isn't working label Apr 27, 2024
@tmvkrpxl0
Copy link
Author

tmvkrpxl0 commented Apr 27, 2024

According to official source, "conditions" must contain "location" field.
But advancements of cc bridges does not. Below is part of place_redrouter.json

    "criteria": {
        "placed_redrouter": {
            "trigger": "minecraft:placed_block",
            "conditions": {
                "block": "cccbridge:redrouter_block"
            }
        }
    }

It just contains "block"

@SammyForReal
Copy link
Collaborator

Thank you for this issue! Yeah that indeed seems to be a mistake from my side. I will try to fix this.

@tmvkrpxl0
Copy link
Author

when?

1 similar comment
@tmvkrpxl0
Copy link
Author

when?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants