How to extend adapter?

[maa-x]

I have extended AdapterLocal to add a method to generate public URLs.

However, there is no convenient way to use this adapter with the Storage class that I can see.

There's a few ways I can think of to make this work, but the easiest might simply be to make _adapter protected. Let me know your thoughts

[abudaan]

You can extend the Storage by extending the public API. But then you would have to implement the new features that you've added to the local adapter to all other adapters as well otherwise you break the abstraction layer which is the main feature and "raison d'être" of this library.

What you can do to use the functionality that you've added to AdapterLocal is:

const configuration = {
  type: StorageType.LOCAL,
  directory: "path/to/directory",
};
const storage = new Storage(configuration);
const adapter = storage.getAdapter() as AdapterLocal;
adapter.yourMethod();

// or:
(storage.adapter as AdapterLocal).yourMethod();

[abudaan]

Alternately you could use the adapter stand-alone:

const configuration = {
  type: StorageType.LOCAL,
  directory: "path/to/directory",
};
const adapter = new AdapterLocal();
adapter.yourMethod();

You can use the full API on an adapter instance directly. You'd only be missing switchAdapter and getAdapter.

[abudaan]

You can extend the protected method _getFileAsUrl in the local adapter. If you add an extra boolean option publicUrl to the options object you can switch between local urls (filepaths) and public urls.

[maa-x]

But then I'd lose the storage abstraction, with callers needing to handle the different storage backends.

What I was hoping was to override the getFileAsUrl method to allow it to generate a public URL, using a custom URL generator.