-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for no_proxy / NO_PROXY #737
Comments
for proxy we are currently using workaround for now should be to unset the proxy variable you use for MMS, because the only access MMS does is in Note: i have no experience in messing with proxies, so the workaround may not be fully correct and self-implementation would be too much for this single package Edit:
|
I don't think const proxy =
process.env['yarn_https-proxy'] ||
process.env.yarn_proxy ||
process.env['npm_config_https-proxy'] ||
process.env.npm_config_proxy ||
process.env.https_proxy ||
process.env.http_proxy ||
process.env.HTTPS_PROXY ||
process.env.HTTP_PROXY; with something like const proxy = getProxyFromUrl(downloadUrl); Where request's getProxyFromUri is just an example for how this might be implemented. Sorry for any confusion. |
i know that this could be done, but like i said it is kinda out-of-scope for this project to handle and should be handle-able by the library actually consuming the proxy |
I am currently blocked from using this package due to the lack of support for
NO_PROXY
.Here is my scenario:
proxy.company-subdomain.com:8080
https://mirror.company-subdomain.com/mongodb-linux[...]
.company-subdomain,localhost
I'd like to see support for NO_PROXY in this package. It looks like it would involve updating MongoBinaryDownload#download such that it resolves the
proxy
similar to request's getProxyFromUri, which returnsnull
if the URL is included in the NO_PROXY variable.Let me know if you are willing to support this and I would be happy to open a pull request.
The text was updated successfully, but these errors were encountered: