Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squants.motion.VolumeFlowSpec is failing #574

Closed
SethTisue opened this issue Dec 6, 2022 · 2 comments
Closed

squants.motion.VolumeFlowSpec is failing #574

SethTisue opened this issue Dec 6, 2022 · 2 comments

Comments

@SethTisue
Copy link
Member

If I clone the repo currently and run sbt squantsJVM/test, I get

[info] VolumeFlowSpec:
[info] VolumeFlow and its Units of Measure
[info] - should create values using UOM factories
[info] - should create values from properly formatted Strings
[info] - should properly convert to all supported Units of Measure
[info] - should return properly formatted strings for all supported Units of Measure *** FAILED ***
[info]   "[0.041666666666666664 ft³/hr]" was not equal to "[1.0 ft³/d]" (VolumeFlowSpec.scala:131)
[info]   Analysis:
[info]   "[0.041666666666666664 ft³/hr]" -> "[1.0 ft³/d]"

this came up over at scala/community-build#1622

@danielrmeyer
Copy link
Contributor

I created this pull request to fix this issue: #623

@SethTisue
Copy link
Member Author

that fixed it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants