-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLF4J Logging Warnings #164
Comments
I think this issue sits on the edge between being an http4s issue and being a toolkit issue. That said, IMHO there's no simple solution: adding logback is absolutely not the right thing to do, as it won't work on scala native and scala.js. Forcing users to decide and pick their own logging framework is probably still the best thing to do. |
I wouldn't go so far as to say that. We could add it for JVM only.
This is literally an http4s issue :) |
Yay, it was probably too bold, sorry |
Not having SLF4J in the toolkit dependency tree would be even better. Is http4s 0.23.x stuck with it? If I'm reading the issue right, it's already removed from 1.0?
But I don't want to be forced to pick a logging framework for the web scrapper I'm quickly typing up and going to use 3 times! IMO, the value of having a toolkit is greatest for people writing fairly small scripts that aren't going to see extensive use. Having to puzzle out a cryptic warning from a non-Typelevel dependency that is somehow the first thing my http4s script prints out is not great ergonomics for that use case. |
I agree.
Yes, stuck in 0.23, removed in 1.0.
😢 yeah this sucks |
That is really unfortunate. So there is no way out until 1.0. Adding an slf4j logger to the toolkit would kind of work, until the user does want to pick a logger, because slf4j also complains about having more than one. |
When I trying running a simple http4s client app with Typelevel Toolkit, I get warnings about SL4FJ at startup:
I can get rid of them with
//> using dep ch.qos.logback:logback-classic:1.5.3
Maybe the toolkit should include a default logging implementation out of the box? I have no interest in remembering to configure logging when I'm trying to do a quick script.
The text was updated successfully, but these errors were encountered: