ubereats.com: ads

[aldobarr]

Prerequisites

• This is NOT a YouTube, Facebook, Twitch or a shortener/hosting site report. These sites MUST be reported by clicking their respective links.
• I read and understand the policy about what is a valid filter issue.
• I verified that this issue is not a duplicate. (Search here to find out.)
• I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
• I did not enable additional filter lists, or I have verified that the issue still occurs without enabling additional filter lists.
• I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
• I am not using uBlock Origin along with other content blockers.
• I have verified that the web browser's built-in content blocker/tracking protection, network wide/DNS blocking, or my VPN is not causing the issue.
• I have verified that other extensions are not causing the issue.
• If this is about a breakage or detection, I have verified that it is caused by uBlock Origin and isn't a site issue.
• I did not answer truthfully to ALL the above checkboxes.

URL(s) where the issue occurs.

https://www.ubereats.com/orders/{ORDER-ID}

Description

There are some new ads on the order page after an order has been placed.

Other extensions used

betterTTV
bitwarden
clickbait remover for youtube
don't fuck with paste
greasemonkey (only 1 script which only interacts on twitch.tv)
hide private mode
return youtube dislike
sponsorblock for youtube
ttv lol pro
translate web pages
youtube high definition
youtube nonstop
youtube spam remover

Screenshot(s)

Screenshot(s)

Configuration

uBlock Origin: 1.57.2
Firefox: 125
filterset (summary):
 network: 187584
 cosmetic: 49816
 scriptlet: 24739
 html: 2061
listset (total-discarded, last-updated):
 added:
  https://gitlab.com/magnolia1234/bypass-paywalls-clean-filters/-/raw/main/bpc-paywall-filter.txt: 0-0, never
  https://raw.githubusercontent.com/liamengland1/miscfilters/master/antipaywall.txt: 2098-0, 5m
  adguard-spyware-url: 1512-120, 8m
  fanboy-thirdparty_social: 68-0, 8m
  ublock-annoyances: 5823-38, 8m
  adguard-spyware: 83498-31917, 8m
 default:
  user-filters: 5-0, never
  ublock-filters: 38196-118, 9m
  ublock-badware: 8548-0, 9m
  ublock-privacy: 907-3, 9m
  ublock-unbreak: 2332-2, 8m Δ
  ublock-quick-fixes: 193-5, 8m Δ
  easylist: 87514-169, 8m
  easyprivacy: 50907-75, 8m
  urlhaus-1: 12635-3, 8m
  plowe-0: 3729-1160, 8m
filterset (user): [array of 5 redacted]
trustedset:
 added: [array of 7 redacted]
hostRuleset:
 added: [array of 8 redacted]
urlRuleset:
 added: [array of 442 redacted]
userSettings:
 advancedUserEnabled: true
hiddenSettings: [none]
supportStats:
 allReadyAfter: 154 ms (selfie)
 maxAssetCacheWait: 43 ms
 cacheBackend: indexedDB
popupPanel:
 blocked: 74
 network:
  ubereats.com: 74
 extended:
  ##.dw.ec
  ##+js(set-constant, Navigator.prototype.globalPrivacyControl, fa…
  ##+js(set-constant, navigator.globalPrivacyControl, false)

[aldobarr]

@stephenhawk8054 I order quite often. Happy to help with my account if needed.

[stephenhawk8054]

@aldobarr The label is just to inform any others who want to look at the case that the issue needs an account to reproduce.

Can you right click on the ads -> Click on Inspect -> It will open Firefox devtools -> Screenshot it here? (It would be better if you can drag the devtools to be bigger before screenshot)

[aldobarr]

@aldobarr The label is just to inform any others who want to look at the case that the issue needs an account to reproduce.

Can you right click on the ads -> Click on Inspect -> It will open Firefox devtools -> Screenshot it here? (It would be better if you can drag the devtools to be bigger before screenshot)

@stephenhawk8054 The last time I ordered I didn't get an ad. Just a self promo to upgrade ubear eats pro. Example:

Thought you might want to see that too. I got the ads back this morning:

Included the actual dom contents as a text file as well in both cases.

[stephenhawk8054]

Yeah, this is difficult to make if just based on the DOM. You can try this as a custom filter

ubereats.com##:matches-path(/orders) main#main-content ol[style^="transform"]:has(> li > a[href]):has-text(Ad)

but I'm not sure if it would cause breakages somewhere else or not.

[aldobarr]

Order just got delivered so I'll try it out next time. Also realistically the only thing that matters on the order page is the delivery estimate and the map. The rest is just fluff imo.

[stephenhawk8054]

I'll convert this to a discussion. It's still a risky filter so anyone can test it as a custom filter

[aldobarr]

Yeah, this is difficult to make if just based on the DOM. You can try this as a custom filter

ubereats.com##:matches-path(/orders) main#main-content ol[style^="transform"]:has(> li > a[href]):has-text(Ad)

but I'm not sure if it would cause breakages somewhere else or not.

@stephenhawk8054 before:

After:

Looks good to me

[aldobarr]

The ad is back so the previous filter isn't catching it anymore

[Yuki2718]

As it requires an account, sharing screenshots of DOM as in #23798 (comment) will be appreciated.

[aldobarr]

ubereats.txt

[Yuki2718]

@aldobarr Can you also take a screenshot of the top tag of the ad? I mean climbing up the DOM tree to the topmost position that still only selects the ad. I'm interested in CSS property of the element (the right-side column).

Meanwhile, test if

ubereats.com##:matches-path(/orders) #main-content div:not([class]) div[class*=" "] > a[class*=" "] > div[class*=" "] > div[class*=" "] > div[class]:has(> div[class*=" "] > div[class*=" "] > div[class*=" "]:has-text(/^Ad$/)):style(border: 16px dotted pink !important;)

properly highlights the ad with a dotted line.

[jaredcat]

@Yuki2718

<div class="h5 gc"><div><div class="bu bh"><div class="h6 d8 al cm"><div class="bh al ak fq cm"><div class="al f6 fr fs"><a href="https://redeem.services.apple/uberappletv?itscg=MC_30000&amp;itsct=atvp_brand_omd&amp;mttn3pid=uber&amp;mttnagencyid=a5e&amp;mttncc=US&amp;mttnsiteid=143238&amp;mttnsubad=04343586" class="ej bh bu af h7 fw ci h8 h9"><div class="ae al am cn"><div class="ak bh ha hb hc hd"><img alt="" role="presentation" src="https://d1g1f25tn8m2e6.cloudfront.net/3781a5a8-3194-44fd-931e-d1cbe9ec0d4d.png" class="he bh ae ag as"></div><div class="fv g0 ak al am hf et"><div class="bh"><div class="b1 bk h2 bm h3"><div class="hg hh hi bu">You’ve unlocked a 30 day free trial of Apple TV+.</div></div><div class="b1 hj bo fd bq e2"><div class="hg hh hi bu">Watch Joel Edgerton &amp; Jennifer Connelly</div></div></div><div class="bh" uj6r4fap9="" ds56w4nil=""><div class="al et bc hk"><div class="al cm hl"><div class="ck hm hn ho hl gv af hp bo hq e1 gq"><div class="hg hh hr bu">Redeem now</div>→</div></div><div class="b1 bo hq e1 gq"><div class="hg hh hr bu">Ad</div></div></div></div></div></div></a></div></div></div></div></div></div>

[jaredcat]

I was able to get to this (just one div off) before my food was delivered:

with:

ubereats.com##:matches-path(/orders) #main-content div:not([class]):has(div[class*=" "] > a[class*=" "] > div[class*=" "] > div[class*=" "] > div[class] > div[class*=" "] > div[class*=" "] > div[class*=" "]:has-text(/^Ad$/)):style(border: 16px dotted pink !important;)

[aldobarr]

The ad was hidden today so whatever update was added for it looks good:

My only complaint would be that the parent element gets left in as undesirable empty space:

But it's a very minor complaint. This is already good as no ad with white space is better than ad 1 trillion %.

[Yuki2718]

We didn't update anything.

[stephenhawk8054]

The ad does not appear simply because their link matches with a generic filter in EasyList

##a[href^="https://ad.doubleclick.net/"]

[aldobarr]

That's weird, I definitely didn't change anything and it wasn't being caught before

[stephenhawk8054]

The previous links did not start with https://ad.doubleclick.net/, that's why they were not caught.

[stephenhawk8054]

It might still leave placeholders and could be a whack-a-mole but we can add the filters based on the ad link if you can right click on it and paste the links when reporting to here whenever you see the ads. The filters could be safer for false positives as well.

For example, if the ad link is https://redeem.services.apple.com/, the filters could look like this:

ubereats.com##:matches-path(/orders) main#main-content div:not([class]) a[class][href^="https://redeem.services.apple.com/"]

[aldobarr]

I actually think this page doesn't need to be so carefully targeted really. The only information of value ever displayed on an order's page is the map for tracking where your driver is and maybe the delivery estimate. The rest is honestly worthless.

[stephenhawk8054]

If a filter is added to the main list, we need to minimize the chance of false positives, especially for the pages we cannot access. To you it might not be an important page, but we cannot speak on behalf of other users and they will submit issues to complain if breakage happens. The filter lists are not designed for just few users.

[Yuki2718]

I also guess the word "Ad" is dependent on your locale settings.

[aldobarr]

@Yuki2718 Here's another one with the top most element selected

[Yuki2718]

Test ubereats.com##:matches-path(/orders) #main-content > div > div > div[class*=" "]:has(> div:not([class]) [class*=" "] > a[class*=" "] > div[class*=" "] > div[class*=" "] > div[class] > div[class*=" "] > div[class*=" "] > div[class*=" "]:has-text(/^Ad$/)):style(border: 16px dotted pink !important;)

[Yuki2718]

It seems .bh is stable, maybe we can use this to make the rule safer.

ubereats.com##:matches-path(/orders) #main-content > div > div > div[class*=" "]:has(> div:not([class]) [class*=" "] > a[class*=" "] > div[class*=" "] > div[class*=" "] > div.bh > div[class*=" "] > div[class*=" "] > div[class*=" "]:has-text(/^Ad$/)):style(border: 16px dotted pink !important;)

[aldobarr]

Do you want me to remove the previous filter? Also just to clarify if you want me to test the first commented filter, the second one or both? (Also, not planning on ordering anything else today so I'll try to get back to you tomorrow)

[Yuki2718]

The first one should cover both the new ad and old, so the previous rule can be removed. The second one is slightly mor targetted, if this works it's better. But it might stop working in future.

[aldobarr]

@Yuki2718 Here's the first one:

and here's the second:

Both seem to work and leave no extra whitespace, at least for the ad I got today. I'll let you know if either stop working.

[aldobarr]

@Yuki2718 The last filter for the ads on the left side are still working, but I'm now getting these popup(modal) ads:

[Yuki2718]

I think this should be addressed in Annoyances filters. Does ubereats.com##div[data-focus-lock-disabled="false"]:has(> #eater-message-desktop-interstitial-v2 > #eater-message-desktop-interstitial-modal) work for you?

[aldobarr]

I do have annoyances enabled but I get that popup anyway. Shows up on the homepage too, so doesn't have to be after ordering.

I'll try that filter and let you know if I see it again