Substitute type arguments when checking type parameter nullability at call site #1070
+107
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1070 +/- ##
============================================
+ Coverage 87.87% 87.88% +0.01%
- Complexity 2210 2217 +7
============================================
Files 85 85
Lines 7190 7196 +6
Branches 1423 1427 +4
============================================
+ Hits 6318 6324 +6
Misses 438 438
Partials 434 434 ☔ View full report in Codecov by Sentry. |
msridhar
reviewed
Nov 11, 2024
Comment on lines
630
to
640
| if (tree instanceof MethodInvocationTree && methodSymbol.type instanceof Type.ForAll) { | ||
| MethodInvocationTree methodInvocationTree = (MethodInvocationTree) tree; | ||
|
|
||
| List<? extends Tree> typeArgumentTrees = methodInvocationTree.getTypeArguments(); | ||
| com.sun.tools.javac.util.List<Type> explicitTypeArgs = convertTreesToTypes(typeArgumentTrees); | ||
|
|
||
| Type.ForAll forAllType = (Type.ForAll) methodSymbol.type; | ||
| Type.MethodType underlyingMethodType = (Type.MethodType) forAllType.qtype; | ||
| invokedMethodType = | ||
| state.getTypes().subst(underlyingMethodType, forAllType.tvars, explicitTypeArgs); | ||
| } |
There was a problem hiding this comment.
This exact logic (or very similar) now appears in multiple places. Can we extract it into a method that returns a method type with the generic type arguments substituted in?
msridhar
changed the title
msridhar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
void genericMethodAndVoidType()in thejspecify/GenericMethodTests.javafile.