How to properly combine multiple platforms into a single solution?

[d-s-h]

Hi,

I'm trying to get a single MSVS solution with two platforms: Windows Win64 and Android AGDE. More platforms will come later.
I used the HelloAndroidAgde sample as a starting point and expanded it for the Win64 platform. Now I have the following target definition:

public class CommonTarget : Sharpmake.ITarget
{
	public Platform Platform;
	public DevEnv DevEnv;
	public Optimization Optimization;
	public AndroidBuildTargets AndroidBuildTargets = AndroidBuildTargets.arm64_v8a | AndroidBuildTargets.x86_64;

	public override string Name
	{
		get
		{
			var nameParts = new List<string>();

			nameParts.Add(Platform.ToString());
			nameParts.Add(Optimization.ToString());
			nameParts.Add(AndroidBuildTargets.ToString());

			return string.Join("_", nameParts);
		}
	}

	public virtual string SolutionPlatformName
	{
		get
		{
			if (Platform == Platform.agde)
			{
				return "AGDE_" + AndroidBuildTargets.ToString();
			}
			else if (Platform == Platform.win64)
			{
				return "Win64";
			}
			else
			{
				var nameParts = new List<string>();

				nameParts.Add(Platform.ToString());
				nameParts.Add(Optimization.ToString());
				nameParts.Add(AndroidBuildTargets.ToString());

				return string.Join("_", nameParts);
			}
		}
	}
	
	public static CommonTarget[] GetDefaultTargets()
	{
		var defaultTarget = new CommonTarget(
			Platform.win64 | Platform.agde,
			DevEnv.vs2022,
			Optimization.Debug | Optimization.Release
		);

		return new[] { defaultTarget };
	}
};

This ends up with all possible and impossible combinations of configurations and dups of projects (by one for each platform).

BTW, a set of solution platforms is ok:

AGDE_arm64_v8a
AGDE_x86_64
Win64

Questions:

1. Ideally I'd like to have only Debug and Release configs if possible.
   Or, at least, is there a way to remove particular configs from the list?
   I certainly don't need "win64_Debug_arm64_v8a" and "win64_Release_arm64_v8a" ones.

2. Is there a way to eliminate project duplicates and use single ones for both platforms?

Thanks in advance.
-- Dmitry

[jspelletier]

Hi,

The solution is quite simple in fact.
in your GetDefaultTargets() just instantiate a List of targets and add several CommonTarget fragment specifications to it.

The way Sharpmake works is that it will generate all the permutations for each target specification that was added
you could do this. The code below is similar to what we do at Ubisoft

public class CommonTarget : Sharpmake.ITarget
{
	public Platform Platform;
	public DevEnv DevEnv;
	public Optimization Optimization;
	public AndroidBuildTargets AndroidBuildTargets = win64_Debug_arm64_v8a;
        public CommonTarget(Platform p, DevEnv d, Optimization o,  AndroidBuildTargets== win64_Debug_arm64_v8a) :
        {
// TODO
        }
       public static CommonTarget[] GetDefaultTargets()
      {
             var result = new List<CommonTarget>();
             result.Add(new CommonTarget(
			Platform.win64,
			DevEnv.vs2022,
			Optimization.Debug | Optimization.Release
		));
     	        result.Add(new CommonTarget(
			Platform.win64,
			DevEnv.vs2022,
			Optimization.Debug | Optimization.Release
                        AndroidBuildTargets: AndroidBuildTargets.arm64_v8a | AndroidBuildTargets.x86_64
		));
               return results;
      }
}

[d-s-h]

Yeah, yesterday I realized that the AndroidBuildTargets flags can be 0 and can be ignored during win64 project generation. So that I was able to split platforms to different solutions using the same sharpmake files.

However no luck with the approach you suggested for a single solution.
Looks like your code has a few misspellings. Here is what I eventually tried:

public class CommonTarget : Sharpmake.ITarget
{
	public Platform Platform;
	public DevEnv DevEnv;
	public Optimization Optimization;
	public AndroidBuildTargets AndroidBuildTargets;

	public CommonTarget() { }

	public CommonTarget(
		Platform platform,
		DevEnv devEnv,
		Optimization optimization,
		AndroidBuildTargets androidBuildTargets = 0
	)
	{
		Platform = platform;
		DevEnv = devEnv;
		Optimization = optimization;
		AndroidBuildTargets = androidBuildTargets;
	}

	public static CommonTarget[] GetDefaultTargets()
	{
		var result = new List<CommonTarget>();
		result.Add(new CommonTarget(
			Platform.win64,
			DevEnv.vs2022,
			Optimization.Debug | Optimization.Release
		   ));
		result.Add(new CommonTarget(
			Platform.agde,
			DevEnv.vs2022,
			Optimization.Debug | Optimization.Release,
			Android.AndroidBuildTargets.arm64_v8a | Android.AndroidBuildTargets.x86_64
		));
	}

This configuration leads to the following exception because it tries to permutate the win64 fragments against the AGDE platform:

Unsupported Android architecture: 0
	@12/06/2023 20:27:55: Exception message (level 0):
	Error encountered while generating Ebru.EbruSolution
	Inner exception message (level 1):
	Unsupported Android architecture: 0

	Stack trace:
	Inner exception stack trace (level 1):
   at Sharpmake.Android.AndroidAgdePlatform.GetPlatformString(ITarget target) in D:\projects\ebru\3rdparty\Sharpmake\Sharpmake.Platforms\Sharpmake.CommonPlatforms\Android\AndroidAgdePlatform.cs:line 44
   at Sharpmake.Util.GetPlatformString(Platform platform, Project project, ITarget target, Boolean isForSolution) in D:\projects\ebru\3rdparty\Sharpmake\Sharpmake\Util.cs:line 1596
   at Sharpmake.Generators.VisualStudio.Sln.Generate(Solution solution, IReadOnlyList`1 solutionConfigurations, String solutionPath, String solutionFile, Boolean addMasterBff, Boolean& updated) in D:\projects\ebru\3rdparty\Sharpmake\Sharpmake.Generators\VisualStudio\Sln.cs:line 581
   at Sharpmake.Generators.VisualStudio.Sln.Generate(Builder builder, Solution solution, List`1 configurations, String solutionFile, List`1 generatedFiles, List`1 skipFiles) in D:\projects\ebru\3rdparty\Sharpmake\Sharpmake.Generators\VisualStudio\Sln.cs:line 110
   at Sharpmake.Generators.GeneratorManager.Generate(Builder builder, Solution solution, List`1 configurations, String solutionFile, List`1 generatedFiles, List`1 skipFiles) in D:\projects\ebru\3rdparty\Sharpmake\Sharpmake.Generators\GeneratorManager.cs:line 158
   at Sharpmake.Builder.GenerateSolutionFile(Object arg) in D:\projects\ebru\3rdparty\Sharpmake\Sharpmake\Builder.cs:line 1226
	Root stack trace (level 0):
   at Sharpmake.Application.Program.CreateBuilderAndGenerate(BaseBuildContext buildContext, Argument parameters, Boolean generateDebugSolution) in D:\projects\ebru\3rdparty\Sharpmake\Sharpmake.Application\Program.cs:line 481
   at Sharpmake.Application.Program.GenerateAll(BaseBuildContext buildContext, Argument parameters) in D:\projects\ebru\3rdparty\Sharpmake\Sharpmake.Application\Program.cs:line 520
   at Sharpmake.Application.Program.Main() in D:\projects\ebru\3rdparty\Sharpmake\Sharpmake.Application\Program.cs:line 307

Separately the targets work fine, but not when they're added together.