Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defensive checking of sample names #118

Open
AmandaBirmingham opened this issue Aug 16, 2021 · 2 comments
Open

Add defensive checking of sample names #118

AmandaBirmingham opened this issue Aug 16, 2021 · 2 comments

Comments

@AmandaBirmingham
Copy link
Collaborator

Modify pipeline to ensure up-front that sample names meet naming convention (split into 5 pieces on a double underscore, start with "SEARCH-", maybe others) and to stop running and provide details of problems if any don't.

@kmfisch
Copy link
Member

kmfisch commented Aug 16, 2021

Also include automated check for merging or not merging based on the sample name, e.g. if two sample names are identical with the exception of the _L001 and _L002, then that would indicate it needs merging.

@AmandaBirmingham
Copy link
Collaborator Author

AmandaBirmingham commented Aug 16, 2021

@kmfisch I'm going to break that out into a separate issue because (per this SP run evaluation thing) we still want to be able to run multi-lane data unmerged, so I see this as a new feature (instead of merged vs unmerged setting, we have merged, unmerged, and auto, where the code detects the merge setting based on sample name). See issue #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants