Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kalman Filter object not re-initialized upon environment 'restart event' #72

Open
Anner-deJong opened this issue Aug 3, 2018 · 1 comment
Labels

Comments

@Anner-deJong
Copy link

Whenever restarting or switching datasets (which includes a restart) in the simulator environment,
the kalman filter object retains its object state (state matrix, process covariance matrix, etc), although the object should be re-initialized.

  • Not reinitializing them actually makes the performance worse on a second run as compared to a first run
  • Not reinitializing upon switching environments can actually make the kalman filter code crash

I printed out the full messages being received from the websocket connection, but there doesnt seem to be one including a flag for either 'restart' or for 'switched datasets'.

Currently seemingly only solution is upon restart, also quit the Kalman filter code and restart the code, but this is cumbersome. Is there a way to make the kalman filter code more robust by receiving some event when the code has to be re-initialized?

@mvirgo
Copy link
Contributor

mvirgo commented Nov 20, 2018

Thanks for reaching out @Anner-deJong! I think this is something we've had as a "like-to-have" for a bit, but haven't ever implemented. I'll keep this open so we can make sure it stays on the radar.

@mvirgo mvirgo added the ready label Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants