Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spinner in the status bar for long running network requests. #10

Open
OwenLaRosa opened this issue Nov 9, 2018 · 3 comments
Open
Labels
moviemanagerchallenge Task for "Improve the Movie Manager" Challenge

Comments

@OwenLaRosa
Copy link
Contributor

We use a UIActivityIndicatorView on the login screen to signal network activity. Apps will also signal network activity for other types of long running tasks (like image downloads).

There's not always a place for an activity indicator view, but iOS does provide the same spinning animation in the status bar. You can enable it with

UIApplication.shared.isNetworkActivityIndicatorVisible = true

And disable it by setting the property to false.

For this task, try using a UIActivityIndicatorView or the one in the status bar, to signal in-progress network requests in another part of the app, like loading the image on the detail view..

@OwenLaRosa OwenLaRosa assigned OwenLaRosa and unassigned OwenLaRosa Nov 9, 2018
@OwenLaRosa OwenLaRosa added the moviemanagerchallenge Task for "Improve the Movie Manager" Challenge label Nov 9, 2018
@aslangaslan
Copy link

Is it right to handle this funcion in setLoggingIn in LoginViewController?

@BrentMifsud
Copy link

BrentMifsud commented Jun 1, 2019

Is it right to handle this funcion in setLoggingIn in LoginViewController?

We already basically have this functionality in the LoginViewController when we added the activity spinner underneath the login buttons. He wants us to add it to the other view controllers where heavy network requests are being created.

Like the search view controller or the movie detail view controller when images are being downloaded.

However, if you do want to add the network indicator. Putting it inside the setLoggingIn would work.

@BrentMifsud
Copy link

If you are using an iPhone X, XS or XS max, the network activity indicator will never be visible.

This issue is only relevant to iPhone 8 and prior.

BrentMifsud pushed a commit to BrentMifsud/TheMovieManager that referenced this issue Jun 2, 2019
BrentMifsud pushed a commit to BrentMifsud/TheMovieManager that referenced this issue Jun 2, 2019
BrentMifsud pushed a commit to BrentMifsud/TheMovieManager that referenced this issue Jun 2, 2019
BrentMifsud pushed a commit to BrentMifsud/TheMovieManager that referenced this issue Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moviemanagerchallenge Task for "Improve the Movie Manager" Challenge
Projects
None yet
Development

No branches or pull requests

3 participants