Use defer to release watch resources for any exit.

udhos · Dec 26, 2023 · 2c1a709 · 2c1a709
1 parent 98e0181
commit 2c1a709
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/kubegroup/kube.go b/kubegroup/kube.go
@@ -233,11 +233,12 @@ func (k *kubeClient) watchOnce(out chan<- podAddress, info *podInfo, table map[s
 		return errWatch
 	}
 
+	defer watcher.Stop()
+
 	in := watcher.ResultChan()
 	for {
 		select {
 		case <-done:
-			watcher.Stop()
 			k.options.Debugf("%s: done channel closed, exiting", me)
 			return nil
 		case event, ok := <-in: