Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for JSON deserialization in api_request #98

Open
coderabbitai bot opened this issue Jun 22, 2024 · 0 comments
Open

Add test coverage for JSON deserialization in api_request #98

coderabbitai bot opened this issue Jun 22, 2024 · 0 comments
Assignees
@bdraco

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 22, 2024

There is currently no test coverage for the JSON deserialization and error management in the method of . This is critical for ensuring the robustness of data handling. It would be beneficial to add tests that cover various scenarios including successful parsing and handling of JSONDecodeError exceptions.

Referenced lines: https://github.com/uilibs/uiprotect/blob/main/src/uiprotect/api.py#L437-L442

This issue was identified during a pull request review: #96 (comment)

@bdraco
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdraco bdraco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bdraco