-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get examples.ipynb working #2941
Conversation
060da6a
to
1375fe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an assertion addition to the CSV test please!
provide new input file and add test for csv_output.py to check all values are positive floats
9b1476d
to
8fbb4d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Clair. A couple of the asserts in the CSV test could be made a bit more concise, but I'm more than happy with everything else in this PR, so I'll merge it. Great!
Description
Fixed problems within
examples
folder. The original input file thatexamples.ipynb
was trying to use did not exist, so gave it a new input file. Thescan.ipynb
file did not have an input file so one was added. Thecsv_output.ipynb
file also did not have an input file, so added one and also changed the list of variables that would be added from the input file to the created csv file. Also added a test forcsv_output.py
which tests that a csv file is created and that the values read in from the input file are all positive floats.Checklist
I confirm that I have completed the following checks: