Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get examples.ipynb working #2941

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Conversation

clmould
Copy link
Collaborator

@clmould clmould commented Sep 12, 2023

Description

Fixed problems within examples folder. The original input file that examples.ipynb was trying to use did not exist, so gave it a new input file. The scan.ipynb file did not have an input file so one was added. The csv_output.ipynb file also did not have an input file, so added one and also changed the list of variables that would be added from the input file to the created csv file. Also added a test for csv_output.py which tests that a csv file is created and that the values read in from the input file are all positive floats.

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould self-assigned this Sep 12, 2023
@clmould clmould linked an issue Sep 12, 2023 that may be closed by this pull request
@clmould clmould marked this pull request as draft September 12, 2023 15:15
@clmould clmould force-pushed the 2891-examples-input-file-doesnt-exist branch from 060da6a to 1375fe7 Compare September 14, 2023 10:39
@clmould clmould marked this pull request as ready for review September 14, 2023 15:00
@clmould clmould requested a review from jonmaddock September 14, 2023 15:01
Copy link
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an assertion addition to the CSV test please!

tests/integration/test_examples.py Show resolved Hide resolved
@clmould clmould requested a review from jonmaddock September 15, 2023 13:15
tests/integration/test_examples.py Outdated Show resolved Hide resolved
@clmould clmould requested a review from jonmaddock September 18, 2023 12:05
tests/integration/test_examples.py Outdated Show resolved Hide resolved
@clmould clmould force-pushed the 2891-examples-input-file-doesnt-exist branch from 9b1476d to 8fbb4d2 Compare September 22, 2023 14:19
@clmould clmould requested a review from jonmaddock September 22, 2023 14:20
Copy link
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Clair. A couple of the asserts in the CSV test could be made a bit more concise, but I'm more than happy with everything else in this PR, so I'll merge it. Great!

@jonmaddock jonmaddock merged commit 0fdb7a5 into main Sep 26, 2023
20 checks passed
@jonmaddock jonmaddock deleted the 2891-examples-input-file-doesnt-exist branch September 26, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples input file doesn't exist
2 participants