Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

724 cpttf and cpttf max error catching integer turns option #3114

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cjwgriesel
Copy link
Contributor

Added exclusion for constraint 77 fcpttf if ixc =60 (cpttf) is selected. Cannot have constraint icc = 77 fcpttf with iteration value ixc = 60 cpttf.

Exclusion for ixc = 60 if i_tf_turns_integer == 1. Cannot have iterated itv ixc = 60 with i_tf_turns_integer == 1.

Exclusion for ixc = 60 if t_turn_tf or t_cable_tf is selected. Cannot have iterated itv ixc == 60 cpttf with t_turn_tf input or t_cable_tf is input.

Added a Warning that if i_tf_turns_integer == 0 and if t_turn_tf or t_cable_tf is selected then cpttf is calculated. It will over write any value of cpttf if it is inputted.

Added a Warning that if i_tf_turns_integer == 0 and if cpttf = 70000.0 and if t_turn_tf or t_cable_tf is not selected then the default value of cpttf has been used if no value of cpttf has been inputted.

Added improved method of detecting if values have been inputted by having three boolean flags t_turn_tf_is_input, t_cable_tf_is_input and cpttf_max_is_input. If any are true then a value has been inputted. Note that at present the cpttf_max_is_input flag is not used as using cpttf_max did not seem to have any effect?? Default value of cpttf_max = 90000.0.

new warnings and errors added to errorlist.json 282 to 286.

Noticed an error in sctfcoil.py and corrected it. i.e.
po.ovarre(
self.outfile,
"WP cross section area (per coil) (m2)",
"(aswp)",
sctfcoil_module.awptf,
)
fixed it by providing the output for both aswp and awptf. This necessitated modifying the test results as the output had changed.

Added a modification to hdf_to_scatter_plot.py where the font size can be selected manually (default set 6) and called it hdf_to_scatter_plot1.py. Not related to this Issue but it is a useful modification for scatterplots.

Copy link
Contributor

@jmorris-uk jmorris-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove HDF update. Otherwise looks fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be included in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cpttf and cpttf_max error catching (integer turns option)
2 participants