Change Variable Names with "/" : Papercut #1722 #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3404 +/- ##
=======================================
Coverage 28.36% 28.36%
=======================================
Files 77 77
Lines 18365 18363 -2
=======================================
Hits 5209 5209
+ Misses 13156 13154 -2 ☔ View full report in Codecov by Sentry. |
ajpearcey
requested changes
Nov 18, 2024
process/io/plot_scans.py
Outdated
| @@ -640,7 +640,7 @@ def main(args=None): | |||
| else f"{args.outputdir}/scan_{scan_var_name}_vs_plasma_current" | |||
| + f".{save_format}" | |||
| ) | |||
| elif output_name == "pdivtbt/qar": | |||
| elif output_name == "pdivtbt_over_qar": | |||
There was a problem hiding this comment.
This else if statement is now unnecessary. It was just to stop an invalid file name being used. This now shouldn't happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1722
Changes Variable names that have "/" in it.
Checklist
I confirm that I have completed the following checks: