From 85087e540c14b7d55a117b136dcbe38ce0e73fa4 Mon Sep 17 00:00:00 2001 From: Jonathan Hollocombe Date: Thu, 27 Jul 2023 11:14:41 +0100 Subject: [PATCH] Trying to fix libfmt linking errors --- source/client/CMakeLists.txt | 14 +++++++------- source/clientserver/CMakeLists.txt | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/source/client/CMakeLists.txt b/source/client/CMakeLists.txt index 4db914e2..7878981a 100755 --- a/source/client/CMakeLists.txt +++ b/source/client/CMakeLists.txt @@ -75,13 +75,13 @@ include_directories( ) add_library( client-objects OBJECT ${SRC_FILES} ${HEADER_FILES} ) -target_link_libraries( client-objects PRIVATE fmt::fmt ) +target_link_libraries( client-objects PUBLIC fmt::fmt ) if( NOT CLIENT_ONLY ) add_library( fatclient-objects OBJECT ${SRC_FILES} ) - target_link_libraries( fatclient-objects PRIVATE fmt::fmt ) + target_link_libraries( fatclient-objects PUBLIC fmt::fmt ) - target_compile_definitions( fatclient-objects PRIVATE -DFATCLIENT ) + target_compile_definitions( fatclient-objects PUBLIC -DFATCLIENT ) endif() set( CLIENT_OBJS @@ -127,18 +127,18 @@ elseif( TIRPC_FOUND ) set( CLIENT_LINK_LIBS ${CLIENT_LINK_LIBS} ${TIRPC_LIBRARIES} ) endif() -target_link_libraries( client-static PRIVATE ${CLIENT_LINK_LIBS} ) +target_link_libraries( client-static PUBLIC ${CLIENT_LINK_LIBS} ) if( BUILD_SHARED_LIBS ) - target_link_libraries( client-shared PRIVATE ${CLIENT_LINK_LIBS} ) + target_link_libraries( client-shared PUBLIC ${CLIENT_LINK_LIBS} ) endif() if( NOT CLIENT_ONLY ) add_library( fatclient-static STATIC ${FATCLIENT_OBJS} ) - target_link_libraries( fatclient-static PRIVATE plugins-static ${CLIENT_LINK_LIBS} ) + target_link_libraries( fatclient-static PUBLIC plugins-static ${CLIENT_LINK_LIBS} ) if( BUILD_SHARED_LIBS ) add_library( fatclient-shared SHARED ${FATCLIENT_OBJS} ) - target_link_libraries( fatclient-shared PRIVATE plugins-shared ${CLIENT_LINK_LIBS} ) + target_link_libraries( fatclient-shared PUBLIC plugins-shared ${CLIENT_LINK_LIBS} ) endif() endif() diff --git a/source/clientserver/CMakeLists.txt b/source/clientserver/CMakeLists.txt index e24cebe9..d3a22060 100755 --- a/source/clientserver/CMakeLists.txt +++ b/source/clientserver/CMakeLists.txt @@ -115,16 +115,16 @@ elseif( TIRPC_FOUND ) endif() add_library( clientserver-client-objects OBJECT ${SRC_FILES} ${HEADER_FILES} ) -target_link_libraries( clientserver-client-objects PRIVATE fmt::fmt ) +target_link_libraries( clientserver-client-objects PUBLIC fmt::fmt ) if( NOT CLIENT_ONLY ) add_library( clientserver-server-objects OBJECT ${SRC_FILES} ) target_compile_definitions( clientserver-server-objects PUBLIC -DSERVERBUILD ) - target_link_libraries( clientserver-server-objects PRIVATE fmt::fmt ) + target_link_libraries( clientserver-server-objects PUBLIC fmt::fmt ) add_library( fatclientserver-objects OBJECT ${SRC_FILES} ) target_compile_definitions( fatclientserver-objects PUBLIC -DFATCLIENT ) - target_link_libraries( fatclientserver-objects PRIVATE fmt::fmt ) + target_link_libraries( fatclientserver-objects PUBLIC fmt::fmt ) endif() file( GLOB HEADER_FILES "*.h" )