Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch settings to en-gb and Europe/London TZ #430

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

marcelkornblum
Copy link
Contributor

https://uktrade.atlassian.net/browse/DWPF-161

Not 100% convinced this is a great idea, though it's definitely nicer user experience for e.g. article published date. Any watch-outs you can think of, perhaps re: infra, logging, etc?

@CamLamb
Copy link
Contributor

CamLamb commented Aug 21, 2023

It might be worth double checking, but I think TIME_ZONE might be used when storing dates/datetimes.
If it is, then you might want to either:

Copy link
Contributor

@CamLamb CamLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice n simple!

@marcelkornblum marcelkornblum merged commit 59557ac into main Aug 24, 2023
@marcelkornblum marcelkornblum deleted the use-timezone branch August 24, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants