Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Share & Download UI for better usability #1454

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Refactor Share & Download UI for better usability #1454

merged 5 commits into from
Jan 2, 2024

Commits on Dec 18, 2023

  1. refactor share dialog for better usability 

    * ordering is now short URL - download - backup - embed ordered by
  easier use cases for everyone to complex iframe code for web experts
* show available formats as buttons instead of hiding them in a dropdown
* add explaining labels
* change the dark options fieldset to light gray
    @jschleic
    jschleic committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    931ac74 View commit details
    Browse the repository at this point in the history

  2. refactor shareBox into separate class 

    download() and format() functions as well as dialog itself and
IFrameExporter helper moved into new file umap.share.js
    @jschleic
    jschleic committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    d19cc60 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. add download icons 

    file icon CC0 from https://www.iconfinder.com/icons/9110902/file_download_icon
arrow down drawn in inkscape
    @jschleic
    jschleic committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    aec4330 View commit details
    Browse the repository at this point in the history

  2. re-style download panel 

    according to suggestion by @Aurelie-Jallut in
umap-project#1454 (comment)
    @jschleic
    jschleic committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    3f6c705 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. cleanup sharebox changes 

    * "data" moved to helptext
* drop css introduced in previous draft
* prettier.js
    @jschleic
    jschleic committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    dbf0179 View commit details
    Browse the repository at this point in the history