Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real tile URL in tests #1467

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Use real tile URL in tests #1467

merged 1 commit into from
Dec 15, 2023

Conversation

yohanboniface
Copy link
Member

It's easier to debug integration tests screenshots (otherwise background is only grey).

Copy link
Contributor

@davidbgk davidbgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it affect tests duration? 🤔

It's easier to debug integration tests screenshots (otherwise
background is only grey).
@yohanboniface
Copy link
Member Author

Good question!

This branch: 212 passed in 51.13s
Master: 212 passed in 49.41s

Only integrations ones:

This branch: 47 passed in 47.04s
Master: 47 passed in 42.88s

So it may not be insignificant…

@yohanboniface yohanboniface merged commit 668bab6 into master Dec 15, 2023
12 checks passed
@yohanboniface yohanboniface deleted the test-tile-url branch December 15, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants