Iconlayers polish #1475
Merged
Iconlayers polish #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this stage, uMap does not distinguish between a custom background and the default background, both are saved in map.options.tilelayer. Given we want a custom background (so not in the list) to appear in the selector, we need this check to be sure we are not adding again one layer from the list
When an editor change the background layer from our own selector, we need to inform iconLayers, so it can update its list and order accordingly
Maybe we should force it through the CI? |
davidbgk
reviewed
Dec 18, 2023
| if (this.customTilelayer) callback.call(context, this.customTilelayer) | ||
| this.tilelayers.forEach((layer) => callback.call(context, layer)) | ||
| const urls = [] | ||
| const callOne = (layer) => { |
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some edge cases of the new tilelayer switcher this morning while testing it a bit more:
A bit of prettier noise…