-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GB drain upgrade handler #2107
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2107 +/- ##
==========================================
- Coverage 75.38% 74.61% -0.78%
==========================================
Files 100 127 +27
Lines 8025 9883 +1858
==========================================
+ Hits 6050 7374 +1324
- Misses 1589 2007 +418
- Partials 386 502 +116
|
Ok, now it's better. I just need to run a quick test to double-check that it does what's supposed to 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- upgrade handler should be merged with the "alpha" one.
- I think we can also remove begin/end blocker of GB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- we should remove begin/end blockers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
If we want to remove the begin/end blocker we'll have to do it on the gb module itself. This should be enough imo: umee-network/Gravity-Bridge#10 |
Description
closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...