Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GB drain upgrade handler #2107

Merged
merged 14 commits into from
Jun 29, 2023
Merged

feat: add GB drain upgrade handler #2107

merged 14 commits into from
Jun 29, 2023

Conversation

facundomedica
Copy link
Contributor

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #2107 (3757ddd) into main (7f05ad4) will decrease coverage by 0.78%.
The diff coverage is 77.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
- Coverage   75.38%   74.61%   -0.78%     
==========================================
  Files         100      127      +27     
  Lines        8025     9883    +1858     
==========================================
+ Hits         6050     7374    +1324     
- Misses       1589     2007     +418     
- Partials      386      502     +116     
Impacted Files Coverage Δ
ante/spam_prevention.go 75.92% <ø> (ø)
x/incentive/codec.go 47.82% <ø> (+9.89%) ⬆️
x/incentive/keeper/invariants.go 0.00% <0.00%> (ø)
x/leverage/client/tests/suite.go 100.00% <ø> (ø)
x/leverage/client/tests/tests.go 100.00% <ø> (ø)
x/leverage/keeper/borrows.go 75.93% <ø> (-2.64%) ⬇️
x/leverage/keeper/collateral.go 72.72% <ø> (-0.16%) ⬇️
x/leverage/keeper/errors.go 100.00% <ø> (ø)
x/leverage/keeper/exchange_rate.go 72.72% <ø> (ø)
x/leverage/keeper/genesis.go 87.23% <ø> (ø)
... and 62 more

... and 25 files with indirect coverage changes

app/upgrades.go Outdated Show resolved Hide resolved
app/upgrades.go Outdated Show resolved Hide resolved
@facundomedica
Copy link
Contributor Author

Ok, now it's better. I just need to run a quick test to double-check that it does what's supposed to 👌

@facundomedica facundomedica marked this pull request as ready for review June 28, 2023 09:06
@facundomedica facundomedica requested a review from a team as a code owner June 28, 2023 09:06
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • upgrade handler should be merged with the "alpha" one.
  • I think we can also remove begin/end blocker of GB

app/upgrades.go Show resolved Hide resolved
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • we should remove begin/end blockers

app/upgrades.go Outdated Show resolved Hide resolved
Copy link
Member

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@facundomedica
Copy link
Contributor Author

If we want to remove the begin/end blocker we'll have to do it on the gb module itself. This should be enough imo: umee-network/Gravity-Bridge#10

@robert-zaremba robert-zaremba added this pull request to the merge queue Jun 29, 2023
Merged via the queue into main with commit cdef40a Jun 29, 2023
25 checks passed
@robert-zaremba robert-zaremba deleted the facu/gbupgrade-drain branch June 29, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants