Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove repeat words #2579

Merged
merged 5 commits into from
Aug 14, 2024
Merged

chore: remove repeat words #2579

merged 5 commits into from
Aug 14, 2024

Conversation

costcould
Copy link
Contributor

@costcould costcould commented Aug 2, 2024

Description

remove repeat words


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • Bug Fixes
    • Corrected typographical errors in comments across various test files for improved clarity.
    • Enhanced error message formatting for better user understanding.
  • Documentation
    • Updated comments in documentation to eliminate typographical errors, ensuring clear descriptions of functions.

Signed-off-by: costcould <fliter@myyahoo.com>
@costcould costcould requested a review from a team as a code owner August 2, 2024 07:38
Copy link
Contributor

coderabbitai bot commented Aug 2, 2024

Walkthrough

The recent changes primarily involve minor textual corrections in comments and documentation across several test and implementation files. These adjustments enhance clarity without affecting the functionality or logic of the code. The updates focus on fixing typographical errors and grammatical issues, ensuring that the documentation accurately reflects the intended meaning within the codebase.

Changes

File Path Change Summary
x/incentive/keeper/scenario_test.go Updated comment in TestZeroBondedAtProgramEnd to correct a typographical error.
x/leverage/types/keys.go Corrected comment for KeyReserveAmount function by fixing a typographical error.
x/leverage/types/token.go Fixed error message formatting in Validate method of Token struct for clarity.
x/uibc/quota/quota_test.go Removed redundant word from comment in TestUnitCheckAndUpdateQuota for grammatical accuracy.

Sequence Diagram(s)

sequenceDiagram
    participant A as Alice
    participant B as System
    A->>B: Initiates unbonding
    B->>A: Processes unbonding request
    A->>B: Confirms action
    B->>A: Updates reward distribution
Loading

🐰 In the code where comments play,
Tiny fixes brighten the day!
With words now clear, mistakes are gone,
Our logic shines, the code moves on.
Hopping forth with joy, we cheer,
Clarity brings us all good cheer! 🥕


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@costcould costcould mentioned this pull request Aug 2, 2024
17 tasks
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4d3c61d and 03d07d7.

Files selected for processing (4)
  • x/incentive/keeper/scenario_test.go (1 hunks)
  • x/leverage/types/keys.go (1 hunks)
  • x/leverage/types/token.go (1 hunks)
  • x/uibc/quota/quota_test.go (1 hunks)
Files skipped from review due to trivial changes (4)
  • x/incentive/keeper/scenario_test.go
  • x/leverage/types/keys.go
  • x/leverage/types/token.go
  • x/uibc/quota/quota_test.go

@gsk967 gsk967 enabled auto-merge August 12, 2024 12:38
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.55%. Comparing base (7f05ad4) to head (723b7e7).
Report is 527 commits behind head on main.

Files Patch % Lines
x/leverage/types/token.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2579       +/-   ##
===========================================
- Coverage   75.38%   62.55%   -12.84%     
===========================================
  Files         100      275      +175     
  Lines        8025    16036     +8011     
===========================================
+ Hits         6050    10032     +3982     
- Misses       1589     5231     +3642     
- Partials      386      773      +387     
Files Coverage Δ
x/leverage/types/keys.go 87.50% <ø> (-12.50%) ⬇️
x/leverage/types/token.go 54.81% <0.00%> (-22.46%) ⬇️

... and 237 files with indirect coverage changes

@gsk967 gsk967 disabled auto-merge August 14, 2024 14:31
@gsk967 gsk967 enabled auto-merge August 14, 2024 14:32
@gsk967 gsk967 disabled auto-merge August 14, 2024 14:32
@gsk967 gsk967 merged commit f88a0de into umee-network:main Aug 14, 2024
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants