Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up render methods in assistant and builders #298

Closed
cnatis opened this issue Apr 23, 2018 · 1 comment
Closed

Split up render methods in assistant and builders #298

cnatis opened this issue Apr 23, 2018 · 1 comment

Comments

@cnatis
Copy link
Contributor

cnatis commented Apr 23, 2018

When trying to extend the assistants/builders I find I have to copy a large code block over and only end up changing a small portion of the code. This is because the render methods are all encompassing, I have been overriding the render methods to render special values, but for the most part the rest of the assistant code is good. I'd like to have these split up a bit more so that if I only need to change the way an option is rendered in the assistant list, I could just override the relevant method.

Some examples that might be a good idea to make extending easier
Assistants

  1. Render archive item
  2. Render suggestion item

Builders

  1. Render single readonly
  2. Render multi readonly
@Ghnuberath
Copy link
Contributor

This is related to #109

@cnatis cnatis closed this as completed Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants