Brainstorming on Reporter
interface definition
#27
Closed
tarkatronic
started this conversation in
General
Replies: 3 comments 3 replies
-
The interface definition looks good. I was just thinking of one thing that might be worth considering: Async vs Sync. Currently, The methods in the Reporter interface are blocking, which means that calling code will be blocked until all reports are sent. We could consider making the reporting methods asynchronous by using channels or goroutines to send reports concurrently. |
Beta Was this translation helpful? Give feedback.
3 replies
-
Alright, I've got all of this implemented in #39. I had to modify the interface a little bit. But I think it's going to work fairly well, for now. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Closing this discussion now, as #39 has been merged! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Working on #5, I'm trying to define an interface for a
Reporter
. The first concrete implementation will be aSlackReporter
. Other ones I have in mind immediately are:What I'm thinking right now is:
This basically matches with how we're currently sending our messages directly to Slack. I think the ideal calling code would be something like:
How does this look? What am I missing here?
Beta Was this translation helpful? Give feedback.
All reactions