Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix build creation #643

Merged
merged 2 commits into from
Oct 2, 2023
Merged

CI: Fix build creation #643

merged 2 commits into from
Oct 2, 2023

Conversation

falko17
Copy link
Collaborator

@falko17 falko17 commented Sep 28, 2023 •
edited
Loading

This fixes two build-related things:

  • Builds in general have been fixed. Previously, they only worked on their second re-run. This was due to certain non-critical errors (apparently related to the RTVoice plugin) appearing only on the first build. As the build is still successful even with these errors present, I implemented a workaround whereby a custom build script always reports the number of errors as zero.1
  • A mistake on parsing manual workflow inputs which has led to inverted booleans has been fixed. Previously, this would have led to inverted inputs for manual builds (e.g., choosing to create both a Windows and Linux build would have resulted in neither).

Footnotes

  1. This should cause no problems because a) the true number of errors is still reported in the log, so it does not get lost, and more importantly b) if a build fails with a critical error, its exit code will reflect that and the build script still fails. This workaround only leads to us not detecting non-critical errors (without consulting the log). ↩

@falko17 falko17 added the no release No new release will be created after a merge when setting this on a PR. label Sep 28, 2023
@falko17 falko17 self-assigned this Sep 28, 2023
@falko17 falko17 changed the title CI: Fix build creation [WIP] CI: Fix build creation Sep 28, 2023
@falko17
CI: Use custom Unity build script
a86db7c 
This should fix current problems in which the first clean build for a
given platform ends successfully, but still produces non-critical
errors, which incorrectly mark the pipeline as having failed.
@falko17 falko17 changed the title [WIP] CI: Fix build creation CI: Fix build creation Sep 29, 2023
@falko17 falko17 requested a review from koschke September 29, 2023 21:43
koschke
koschke approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@koschke koschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine. Can be merged.

@koschke koschke merged commit afde8b6 into master Oct 2, 2023
10 checks passed
@koschke koschke deleted the fix-ci branch October 2, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koschke koschke koschke approved these changes

Assignees

@falko17 falko17

Labels
no release No new release will be created after a merge when setting this on a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@falko17 @koschke