Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Downgrade to 10.0.22621 for Build Tools compatibility #1109

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Nov 19, 2024

GitHub Issue (If applicable): related to unoplatform/uno#18840

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The latest version of Build Tools is unsupported by Microsoft Store and block users from publishing their apps

What is the new behavior?

Downgraded until support is added

PR Checklist

Please check if your PR fulfills the following requirements:

  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph
Copy link
Contributor

nickrandolph commented Nov 19, 2024

@MartinZikmund we should adjust the unoapp template for similar reason, specifically the TFMs:

"value": "net8.0-android;net8.0-ios;net8.0-maccatalyst;net8.0-windows10.0.26100;net8.0-browserwasm;net8.0-desktop;net8.0"

@MartinZikmund MartinZikmund changed the title fix: Downgrade BuildTools fix: Downgrade to 10.0.22621 for Build Tools compatibility Nov 19, 2024
@nickrandolph
Copy link
Contributor

@MartinZikmund this PR should fix the build issues in this PR

@nickrandolph
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nickrandolph nickrandolph force-pushed the dev/mazi/downgrade-buildtools branch from 4c7c69a to df9390b Compare November 20, 2024 07:16
@nickrandolph nickrandolph force-pushed the dev/mazi/downgrade-buildtools branch from df9390b to 8051ac9 Compare November 21, 2024 04:07
@MartinZikmund MartinZikmund merged commit 40b11fe into main Nov 21, 2024
66 checks passed
@MartinZikmund MartinZikmund deleted the dev/mazi/downgrade-buildtools branch November 21, 2024 04:46
@MartinZikmund MartinZikmund restored the dev/mazi/downgrade-buildtools branch December 9, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants