-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] NavigationView
doesn't initially update Flyout position
#18024
Comments
After more investigation, actually the correct behavior seems to be that the Flyout shouldn't open at all at that point and the correct item should be selected. |
So why is the Hamburger icon missing at the top left of the screen? This should open and close the menu but that option is not enabled |
Thank you for the clarification, @cconner100. In the video I shared, there is a HotReload indicator that is covering the actual button. You can move it by dragging the two lines. Is that what you were referring to? 🤔 |
Yes can drag it but the hamburger menu is still not showing in my example
From: Dominik Titl ***@***.***>
Date: Wednesday, August 28, 2024 at 6:35 PM
To: unoplatform/uno ***@***.***>
Cc: curtis conner ***@***.***>, Mention ***@***.***>
Subject: Re: [unoplatform/uno] [Android] `NavigationView` doesn't initially update Flyout position (Issue #18024)
Thank you for the clarification, @cconner100<https://github.com/cconner100>. In the video I shared, there is a HotReload indicator that is covering the actual button. You can move it by dragging the two lines. Is that what you were referring to? 🤔
—
Reply to this email directly, view it on GitHub<#18024 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHGD6PX2CJDIQ7BWG3XFXDZTWYYVAVCNFSM6AAAAABNEA4676VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJVGA3TGNRUGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@cconner100 Could you please post a screenshot after moving the HotReload indicator away? |
I can move it and its still not showing but if I disable hot-reload from my source, the hamburger shows. Currently moving the hotReload sometimes works sometimes not. So for now the android works if I disable the hot reload
From: Youssef Victor ***@***.***>
Date: Thursday, August 29, 2024 at 5:14 PM
To: unoplatform/uno ***@***.***>
Cc: curtis conner ***@***.***>, Mention ***@***.***>
Subject: Re: [unoplatform/uno] [Android] `NavigationView` doesn't initially update Flyout position (Issue #18024)
@cconner100<https://github.com/cconner100> Could you please post a screenshot after moving the HotReload indicator away?
—
Reply to this email directly, view it on GitHub<#18024 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHGD6PEROJBWJGVMGYK5TDZT3X6XAVCNFSM6AAAAABNEA4676VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJXGIZTSMRUHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
The flyout issue is a pointers issue where we get an extra incorrect <NavigationView x:Name="NavigationView" PaneDisplayMode="LeftCompact">
<NavigationView.MenuItems>
<NavigationViewItem Content="Sub Menu 1" Icon="Keyboard" ToolTipService.ToolTip="Sub Menu 1">
<NavigationViewItem.MenuItems>
<NavigationViewItem Content="Notes" Icon="Page" ToolTipService.ToolTip="Notes"/>
</NavigationViewItem.MenuItems>
</NavigationViewItem>
</NavigationView.MenuItems>
<Frame x:Name="ContentFrame" />
</NavigationView> At the following state: Clicking on "Notes" will first cause Tapped event on that NavigationViewItem, which will cause the pane to be closed. Then, we get another incorrect Tapped event on "Sub Menu 1" which will cause it to open as a flyout. |
The fix for this issue will be merged shortly, we had to confirm it is valid across all targets |
Current behavior
Screen.Recording.2024-08-26.142847.mp4
Expected behavior
No response
How to reproduce it (as minimally and precisely as possible)
Workaround
No response
Works on UWP/WinUI
Yes
Environment
No response
NuGet package version(s)
No response
Affected platforms
Android, iOS?
IDE
Visual Studio 2022
IDE version
No response
Relevant plugins
No response
Anything else we need to know?
No response
The text was updated successfully, but these errors were encountered: