Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Avoid non-UIElement items in ChildrenShadow #18474

Open
MartinZikmund opened this issue Oct 15, 2024 · 1 comment
Open

[iOS] Avoid non-UIElement items in ChildrenShadow #18474

MartinZikmund opened this issue Oct 15, 2024 · 1 comment
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform

Comments

@MartinZikmund
Copy link
Member

What would you like to be added

In some cases, iOS adds custom temporary UIViews (accessibility/input related). as children of our UIElements. This is a problem as Children as a UIElementCollection assumes that there will be no null items. Hence we need to make sure to filter away the non-UIElement children and avoid their projection to Children as null

Why is this needed

Reliability.

For which platform

iOS

Anything else we need to know?

No response
@MartinZikmund MartinZikmund added kind/enhancement New feature or request platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI labels Oct 15, 2024
@MartinZikmund MartinZikmund mentioned this issue Oct 15, 2024
Merged
6 tasks
This was referenced Oct 16, 2024
Merged
Merged
@Youssef1313
Copy link
Member

NOTE: When fixing this, the workaround in #18470 can be reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartinZikmund @Youssef1313