Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uno.Sdk should implicitly support SourceLink for library projects #18668

Closed
mikernet opened this issue Nov 3, 2024 · 4 comments
Closed

Uno.Sdk should implicitly support SourceLink for library projects #18668

mikernet opened this issue Nov 3, 2024 · 4 comments
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification

Comments

@mikernet
Copy link
Contributor

mikernet commented Nov 3, 2024

What would you like to be added

SourceLink "just works" without having to reference source link packages in MS SDK when using .net 8+. Uno.Sdk requires adding references to source link packages explictly.

Why is this needed

Reduce friction from moving over from MS SDK.

For which platform

WebAssembly, Android, iOS, Mac Catalyst, Skia (WPF), Skia (Linux X11), Skia (macOS), Skia (Linux Framebuffer), Skia (GTK), Windows (WinAppSDK)

Anything else we need to know?

No response

@mikernet mikernet added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification labels Nov 3, 2024
@jeromelaban
Copy link
Member

The uno.sdk is using the official Microsoft.Net.Sdk which provides this feature. How do you see that this is not supported by default?

@jeromelaban jeromelaban added the triage/needs-information Indicates an issue needs more information in order to work on it. label Nov 4, 2024
@mikernet
Copy link
Contributor Author

mikernet commented Nov 4, 2024

It requires the SourceLink nuget package to be added AFAICT. MS SDK does not.

@github-actions github-actions bot removed the triage/needs-information Indicates an issue needs more information in order to work on it. label Nov 4, 2024
@jeromelaban
Copy link
Member

Sure, but how to do you see that it's not working? How do you validate that sourcelink is not enabled in your package?

@mikernet
Copy link
Contributor Author

mikernet commented Nov 4, 2024

Hmm...can't repro now on a new project. Maybe something else was the issue before. But it was through NuGet Package Manager.

@mikernet mikernet closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Development

No branches or pull requests

2 participants