Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add .NET 7 support #10019

Merged
merged 70 commits into from
Oct 11, 2022
Merged

feat: Add .NET 7 support #10019

merged 70 commits into from
Oct 11, 2022

Conversation

jeromelaban
Copy link
Member

@jeromelaban jeromelaban commented Sep 29, 2022 •
edited
Loading

PR Type

What kind of change does this PR introduce?

  • Feature

What is the new behavior?

Adds support for .NET 7 for WebAssembly and Skia. The reference API also uses .NET 7 which allows Uno internals to benefit from the newer language and runtime features.

The netstandard2.0 target for cross-runtime libraries is still supported.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@gitpod-io
Copy link

gitpod-io bot commented Sep 29, 2022

@jeromelaban jeromelaban changed the title Misc upgades to .NET 7 Misc upgrades to .NET 7 Sep 29, 2022
@jeromelaban jeromelaban force-pushed the dev/jela/net7-interop-test branch from ef9d99d to 4a946ad Compare September 29, 2022 19:48
@jeromelaban
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jeromelaban jeromelaban force-pushed the dev/jela/net7-interop-test branch 8 times, most recently from 183a286 to 8cdd789 Compare October 5, 2022 13:28
@jeromelaban
Copy link
Member Author

/azp run

@jeromelaban jeromelaban marked this pull request as ready for review October 5, 2022 13:46
@jeromelaban jeromelaban marked this pull request as draft October 5, 2022 13:47
@jeromelaban jeromelaban changed the title Misc upgrades to .NET 7 feat: Add .NET 7 support Oct 5, 2022
@jeromelaban jeromelaban force-pushed the dev/jela/net7-interop-test branch 4 times, most recently from 75f7b7b to c7d7070 Compare October 7, 2022 12:34
@jeromelaban
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Youssef1313
Copy link
Member

Youssef1313 commented Oct 8, 2022 •
edited
Loading

@jeromelaban The failure is due to dotnet/arcade#11188 (commented to save time in case you haven't already found the issue)

@jeromelaban jeromelaban marked this pull request as ready for review October 9, 2022 02:12
@jeromelaban jeromelaban force-pushed the dev/jela/net7-interop-test branch from fc93a33 to 8b36a15 Compare October 9, 2022 02:12
@unoplatform unoplatform deleted a comment from nventive-devops Oct 9, 2022
@unoplatform unoplatform deleted a comment from nventive-devops Oct 9, 2022
@unoplatform unoplatform deleted a comment from azure-pipelines bot Oct 9, 2022
@unoplatform unoplatform deleted a comment from azure-pipelines bot Oct 9, 2022
@unoplatform unoplatform deleted a comment from nventive-devops Oct 9, 2022
@unoplatform unoplatform deleted a comment from nventive-devops Oct 9, 2022
@unoplatform unoplatform deleted a comment from nventive-devops Oct 9, 2022
@unoplatform unoplatform deleted a comment from nventive-devops Oct 9, 2022
@unoplatform unoplatform deleted a comment from nventive-devops Oct 9, 2022
@unoplatform unoplatform deleted a comment from nventive-devops Oct 9, 2022
@unoplatform unoplatform deleted a comment from nventive-devops Oct 9, 2022
@unoplatform unoplatform deleted a comment from nventive-devops Oct 9, 2022
@unoplatform unoplatform deleted a comment from nventive-devops Oct 9, 2022
@nventive-devops
Copy link
Contributor

The build 58040 found UI Test snapshots differences: android-28-xamarin: 0, android-28-xamarin-Snap: 0, ios: 54, ios-Snap: 88, macOS-screenshots: 35, skia-gtk-screenshots: 15, skia-wpf-screenshots: 13, wasm: 32, wasm-automated-net6.0-Benchmarks: 0, wasm-automated-net6.0-Default: 7, wasm-automated-net6.0-RuntimeTests: 0, wasm-automated-net7.0-Benchmarks: 0, wasm-automated-net7.0-Default: 0, wasm-automated-net7.0-RuntimeTests: 0

Details

  • android-28-xamarin: 0 changed over 0

  • android-28-xamarin-Snap: 0 changed over 0

  • ios: 54 changed over 293

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ContentPresenter_Template_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Template
    • Flyout_ShowAt_Window_Content_UITests_Windows_UI_Xaml_Controls_FlyoutTests_Flyout_ShowAt_Window_Content
    • Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • ListView_ObservableCollection_Creation_Count_Added_above
    • ListView_ObservableCollection_Creation_Count_Removed_above
    • ListView_ObservableCollection_Creation_Count_Scrolled1
    • ListView_ObservableCollection_Creation_Count_Scrolled2
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
    • ListView_ChangingText_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Changing_Text
    • ListView_ObservableCollection_Creation_Count_Added
    • Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-1
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-3
    • Screenshots_Image_Stretch_Algmnt_Inf_Vertical_Mode-1
    • Screenshots_Image_Stretch_Algmnt_Inf_Vertical_Mode-2
    • Screenshots_Image_Stretch_Algmnt_Inf_Vertical_Mode-3

  • ios-Snap: 88 changed over 995

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AutoSuggestBox_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Description_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Description
    • Border_AutoBorderStretchwithleftmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithleftmargin
    • Border_BorderTopwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderTopwithmargins
    • Border_Border_Corner_Overlap_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerOverlap
    • Border_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Toggle_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Toggle
    • Brushes_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Change_Stops_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Change_Stops
    • Brushes_UITests_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_Formats_UITests_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_Formats
    • Border_AutoBorderStretchwithtopmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithtopmargin
    • Border_BorderLeftwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderLeftwithmargins
    • Border_BorderRightwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderRightwithmargins
    • Brushes_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY
    • Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
    • Buttons_Hyperlink_CanExecute_False_nVentive_Umbrella_Views_UI_Samples_Content_UITests_ButtonTestsControl_Hyperlink_CanExecute_False
    • ComboBox_ComboBox_ScrollViewer_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ScrollViewer
    • ComboBox_ComboBox_SelectedIndex_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_SelectedIndex
    • ComboBox_ComboBox_SelectedItem_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_SelectedItem
    • Default_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ProportionalPanel_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ProportionalPanel
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping
    • ComboBox_ComboBox_ItemsSource_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ItemsSource
    • ComboBox_ComboBox_MaxDropdownHeight_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_MaxDropdownHeight

  • macOS-screenshots: 35 changed over 1068

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • BreadcrumbBar-BreadcrumbBarPage.png
    • Animations-BeginTime_MultipleAnimations.png
    • Brushes-ImageBrushWithScaleTransform.png
    • ColorPicker-WinUIColorPickerPage.png
    • Focus-GetFocus.png
    • Image-Image_Stretch_Alignment_Equal.png
    • Image-Image_Stretch_None_ScrollViewer.png
    • Image-Image_Formats.png
    • Image-LoadFromBytes.png
    • ListView-ListViewIncrementalLoading.png
    • ListView-ListView_With_ListViews_Count_Measure.png
    • MUX-NavigationViewTopNavPage.png
    • MUX-PagerControlPage.png
    • MUX-SplitButtonPage.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • PagerControl-PagerControlPage.png
    • MediaPlayerElement-Using .flv.png
    • MediaPlayerElement-Using .mkv.png
    • MediaPlayerElement-Using .ogg.png

  • skia-gtk-screenshots: 15 changed over 1060

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Date Picking-CalendarView_Theming.png
    • Image-Image_Stretch.png
    • Image-UniformToFill100x100.png
    • MUX-TabViewPage.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • NavigationView-NavigationViewCompactPaneLengthTestPage.png
    • Progress-WindowsProgressRing_GH1220.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • PipsPager-PipsPagerPage.png
    • Windows.Security-AuthenticationBroker_Demo.png
    • Transform-TransformToVisual_Translate2d.png
    • WinUI-PipsPagerPage.png

  • skia-wpf-screenshots: 13 changed over 1060

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes-Ellipse.png
    • Automation-AutomationProperties_Name.png
    • Date Picking-CalendarView_Theming.png
    • Image-UniformToFill100x100.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Progress-WindowsProgressRing_GH1220.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • PipsPager-PipsPagerPage.png
    • Transform-TransformToVisual_Translate2d.png
    • Windows.Security-AuthenticationBroker_Demo.png

  • wasm: 32 changed over 1003

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.NavigationViewAnimationPage
    • MUXControlsTestApp.NavigationViewRS4Page
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderImage
    • MUXControlsTestApp.NavigationViewMinimalPage
    • MUXControlsTestApp.PaneLayoutTestPage
    • MUXControlsTestApp.PipsPagerPage
    • SamplesApp.Samples.UnitTests.HttpUnitTests
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_CustomSources
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewVariableHeightComplexTemplate
    • UITests.Microsoft_UI_Xaml_Controls.TabViewTests.TabViewPage
    • UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_MaxDropdownHeight
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_Infinite_Breadth
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_With_ListViews_Count_Measure
    • UITests.Uno_Web.Http.CookieManagerTests
    • UITests.Shared.Windows_UI_Xaml_Media.Transform.Basics
    • UITests.Windows_UI_ViewManagement.ApplicationViewSizing
    • UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220

  • wasm-automated-net6.0-Benchmarks: 0 changed over 1

  • wasm-automated-net6.0-Default: 7 changed over 879

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • DatePicker_Flyout_DatePicker_-_Flyout
    • MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
    • ScrollBar_Vertical_initial_indicators
    • SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features

  • wasm-automated-net6.0-RuntimeTests: 0 changed over 1

  • wasm-automated-net7.0-Benchmarks: 0 changed over 1

  • wasm-automated-net7.0-Default: 0 changed over 879

  • wasm-automated-net7.0-RuntimeTests: 0 changed over 1

dr1rrb
dr1rrb approved these changes Oct 11, 2022
View reviewed changes
build/ci/.azure-devops-uap.yml Show resolved Hide resolved
@jeromelaban jeromelaban merged commit 5b2e1b8 into master Oct 11, 2022
@jeromelaban jeromelaban deleted the dev/jela/net7-interop-test branch October 11, 2022 13:22
@Youssef1313 Youssef1313 mentioned this pull request Oct 11, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@dr1rrb dr1rrb dr1rrb approved these changes

@carldebilly carldebilly carldebilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromelaban @Youssef1313 @nventive-devops @carldebilly @dr1rrb