fix(wasm): unwanted preview shown when dragging over existing selection #18921

Xiaoy312 · 2024-11-25T22:56:51Z

GitHub Issue (If applicable): closes #18854, closes unoplatform/kahua-private#228

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

On WebAssembly, when there is selection underneath or around a control that typically uses drag gesture (eg: ScrollBar or Slider), the drag gesture will only work for the 1st frame/tick/delta, subsequent pointer capture events are lost, and there is an undesired browser dragging preview that follows the cursor.

What is the new behavior?

The browser dragstart event are globally blocked. Note that doesn't affect the DragEventArgs.DragUIOverride preview as that is rendered on the uno side, nor the control's ability to receive drop (handled via dragenter & dragleave).

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Other information

Xiaoy312 · 2024-11-25T23:08:14Z

to test this change:

goto: https://calm-bush-053c9c20f-staging.eastus2.2.azurestaticapps.net/
run from command: document.addEventListener('dragstart', e => e.preventDefault())

@dr1rrb while this doesnt break the uno drag-n-drop. we have issue with native drag-n-drop, as that is effectively disabled...
what i mean by that is you can no longer drag-n-drop document selection into "drop-recipients"(eg: [internal] control that handles DragEnter, or [external] browser title bar for opening the link/googling the selection):

is this acceptable?
^ edit: no
^ edit2: actually, yes~

unodevops · 2024-11-26T00:38:35Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18921/index.html

unodevops · 2024-11-26T02:34:25Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18921/index.html

unodevops · 2024-11-26T04:59:58Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18921/index.html

unodevops · 2024-11-26T07:05:32Z

⚠️⚠️ The build 148431 has failed on Uno.UI - CI.

dr1rrb · 2024-11-26T14:14:12Z

to test this change:
* goto: https://calm-bush-053c9c20f-staging.eastus2.2.azurestaticapps.net/

* run from command: `document.addEventListener('dragstart', e => e.preventDefault())`
@dr1rrb while this doesnt break the uno drag-n-drop. we have issue with native drag-n-drop, as that is effectively disabled... what i mean by that is you can no longer drag-n-drop document selection into "drop-recipients"(eg: [internal] control that handles DragEnter, or [external] browser title bar for opening the link/googling the selection):

is this acceptable? ^ edit: no

Yes it acceptable ... and it's actually the preferred behavior. Just like the right click and text selection has been disabled in the browser, we need to disable that. Uno's app are application embedded in a browser. It has to be opt-in if you want to restore that behavior, and the way to opt-in is to use the WinUI APIs of drag and drop, not injecting JS.

src/Uno.UI/UI/Xaml/Controls/Slider/Slider.Uno.cs

unodevops · 2024-11-26T16:40:12Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18921/index.html

unodevops · 2024-11-26T19:47:17Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18921/index.html

unodevops · 2024-11-26T23:17:14Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18921/index.html

unodevops · 2024-11-27T00:28:28Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18921/index.html

nventive-devops · 2024-11-27T04:46:35Z

The build 148557 found UI Test snapshots differences: android-28-net8: 35, android-28-net8-Snap: 53, ios: 6, ios-Snap: 40, skia-gtk-screenshots: 65, skia-linux-screenshots: 53, skia-windows-screenshots: 50, wasm: 422, wasm-automated-net9.0-UWP-Default-automated: 26, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 35 changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨
- CheckBox_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated
- Button_NestedButtons_Validation_nVentive_Umbrella_Views_UI_Samples_Content_UITests_ButtonTestsControl_Nested_Buttons
- CheckBox_DoubleTapValidation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- FocusManager_GetFocusedElement_Rectangle_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
- TextBox_CharacterCasingLower_ShouldBeAllLower_Test_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_CharacterCasing
- NavigateBackAndForthBetweenMenuItemsAndSettings_Fluent_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
- WebView_NavigateToAnchor_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- TextBox_CharacterCasingNormal_ShouldAcceptAllCasing_Test_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_CharacterCasing
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_Hardware_Back_Button_Pressed_UITests_Windows_UI_Core_SystemNavigationManagerTests_HardwareBackButton
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
android-28-net8-Snap: 53 changed over 1068
🚨🚨 Comparison Details (first 20) 🚨🚨
- Brushes_UITests_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_Formats_UITests_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_Formats
- Shapes_SamplesApp_Windows_UI_Xaml_Shapes_EllipsePage_SamplesApp_Windows_UI_Xaml_Shapes_EllipsePage
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
- RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
- TextBlock_TextBlock_LineHeight_Multiline_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_LineHeight_Multiline
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- ListView_ListView_DataTemplateSelector_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_DataTemplateSelector
- Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
- MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
- Transform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics
- Brushes_ImageBrushChangingCornerRadius_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushChangingCornerRadius
- TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
- TextBox_TextBox_HorizontalAlignment_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_HorizontalAlignment
- Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
- NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
- Scrolling_MUXControlsTestApp_ScrollViewDynamicPage_MUXControlsTestApp_ScrollViewDynamicPage
- Scrolling_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage
ios: 6 changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
ios-Snap: 40 changed over 1059
🚨🚨 Comparison Details (first 20) 🚨🚨
- Brushes_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
- Grid_Grid_DataBound_ColumnRow_Definitions_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_DataBound_ColumnRow_Definitions
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Margin_Large_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Margin_Large
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
- NavigationView_MUXControlsTestApp_NavigationViewMinimalPage_MUXControlsTestApp_NavigationViewMinimalPage
- NavigationView_MUXControlsTestApp_NavigationViewRS3Page_MUXControlsTestApp_NavigationViewRS3Page
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider
- Windows_System_Display_DisplayRequest_UITests_Shared_Windows_System_Display_DisplayRequest
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
- TextBlock_TextBoxSizeChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBoxSizeChanging
- Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
- Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
- ListView_ListViewGroupedChanging_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGroupedChanging
- Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_ExecuteScriptAsync_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_ExecuteScriptAsync
skia-gtk-screenshots: 65 changed over 2234
🚨🚨 Comparison Details (first 20) 🚨🚨
- Focus_FocusVisual_Properties.png-dark
- UIElement_MeasureDirtyPath.png-dark
- UIElement_MeasureDirtyPath.png
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- WinUIExpanderPage.png-dark
- WinUIProgressBarSimple.png-dark
- WinUIProgressBarSimple.png
- CalendarView_Theming.png-dark
- CalendarView_Theming.png
- Ellipse.png-dark
- Ellipse.png
- Examples.png
- ImageIconPage.png-dark
- ImageIconPage.png
- ImageSourceUrlMsAppDataScheme.png-dark
- ImageSourceUrlMsAppDataScheme.png
- NetworkInformation.png-dark
- NetworkInformation.png
- SvgImageSource_FromStream.png-dark
skia-linux-screenshots: 53 changed over 2234
🚨🚨 Comparison Details (first 20) 🚨🚨
- Buttons.png
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- Focus_FocusVisual_Properties.png-dark
- BorderImageBrushRelativeTransform.png-dark
- BorderImageBrushRelativeTransform.png
- CalendarView_Theming.png-dark
- ButtonClippingTestsControl.png-dark
- Gamepad_CurrentReading.png-dark
- Buttons.png-dark
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
- DoubleImageBrushInList.png-dark
- DoubleImageBrushInList.png
- ClipboardTests.png-dark
- ImageWithLateSourceUniformToFill.png-dark
- ImageWithLateSourceUniformToFill.png
- ClipboardTests.png
- DisplayInformation.png-dark
- DisplayInformation.png
skia-windows-screenshots: 50 changed over 2234
🚨🚨 Comparison Details (first 20) 🚨🚨
- ButtonClippingTestsControl.png
- Buttons.png-dark
- ExpanderColorValidationPage.png-dark
- ExpanderColorValidationPage.png
- ClipboardTests.png-dark
- ClipboardTests.png
- ContentPresenter_NativeEmbedding.png-dark
- ContentPresenter_NativeEmbedding.png
- Gamepad_CurrentReading.png-dark
- ButtonClippingTestsControl.png-dark
- Buttons.png
- DisplayInformation.png-dark
- DisplayInformation.png
- Ellipse.png-dark
- Ellipse.png
- Focus_FocusVisual_Properties.png-dark
- Focus_FocusVisual_Properties.png
- CalendarView_Theming.png
- ImageIconPage.png-dark
- ImageIconPage.png
wasm: 422 changed over 1045
🚨🚨 Comparison Details (first 20) 🚨🚨
- initial_state
- MUXControlsTestApp.NavigationViewBlankPage1
- MUXControlsTestApp.PipsPagerPage
- SamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_Pane_Automated
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_CornerRadius
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
- SamplesApp.Windows_UI_Xaml.Clipping.XamlButtonWithClipping_Scrollable
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderFooterOnly
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Changing_Text
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Expandable_Item
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchUniformAutoSize
- UITests.Shared.Microsoft_UI_Xaml_Controls.RadioMenuFlyoutItemTests.RadioMenuFlyoutItemPage
- UITests.Shared.Windows_UI_Xaml.FrameworkElementTests.FrameworkElement_UnloadedMeasure
- UITests.Shared.Windows_UI_Xaml.FrameworkElementTests.ItemsControl_Loaded
- UITests.Shared.Windows_UI_Xaml.FrameworkElementTests.XamlEvent_Leak
- UITests.Shared.Windows_UI_Xaml_Controls.Flyout.Flyout_ButtonInContent
- UITests.Shared.Windows_UI_Xaml_Controls.Flyout.Flyout_LargeContent
- UITests.Shared.Windows_UI_Xaml_Controls.TextBoxes.TextBox_NaturalSize
- UITests.Shared.Windows_UI_Xaml_Controls.TextBoxTests.TextBox_CharacterCasing
- UITests.Windows_UI_Xaml.UIElementTests.UIElement_InitializationSequence
wasm-automated-net9.0-UWP-Default-automated: 26 changed over 1948
🚨🚨 Comparison Details (first 20) 🚨🚨
- ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- Default_StrokeThickness_MyPath
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- ListView_ListViewHeaderImage_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderImage
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource
- Default_StrokeThickness_MyEllipse
- Default_StrokeThickness_MyEllipse_0_StrokeThickness
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
- WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic
- TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

unodevops · 2024-11-27T06:10:47Z

⚠️⚠️ The build 148557 has failed on Uno.UI - CI.

Xiaoy312 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2024

This comment was marked as outdated.

Sign in to view

Xiaoy312 requested a review from dr1rrb November 26, 2024 01:02

Xiaoy312 force-pushed the dev/xygu/20241125/wasm-pointerdown-over-selection-2 branch from d2b3967 to 9e62116 Compare November 26, 2024 01:15

github-actions bot added the platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform label Nov 26, 2024

Xiaoy312 force-pushed the dev/xygu/20241125/wasm-pointerdown-over-selection-2 branch from 9e62116 to 210bae8 Compare November 26, 2024 02:05

dr1rrb reviewed Nov 26, 2024

View reviewed changes

src/Uno.UI/UI/Xaml/Controls/Slider/Slider.Uno.cs Outdated Show resolved Hide resolved

Xiaoy312 force-pushed the dev/xygu/20241125/wasm-pointerdown-over-selection-2 branch from 210bae8 to fb0185a Compare November 26, 2024 14:57

github-actions bot removed the platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform label Nov 26, 2024

Xiaoy312 force-pushed the dev/xygu/20241125/wasm-pointerdown-over-selection-2 branch from fb0185a to b6dfeab Compare November 26, 2024 16:03

github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Nov 26, 2024

dr1rrb approved these changes Nov 26, 2024

View reviewed changes

dr1rrb mentioned this pull request Nov 26, 2024

[Gallery][WASM] [Textbox] Unintended Text Selection unoplatform/Uno.Themes#1459

Closed

5 tasks

Xiaoy312 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2024

Xiaoy312 marked this pull request as ready for review November 26, 2024 21:34

fix(wasm): unwanted preview shown when dragging over existing selection

2436ac6

Xiaoy312 force-pushed the dev/xygu/20241125/wasm-pointerdown-over-selection-2 branch from b6dfeab to 2436ac6 Compare November 26, 2024 21:36

dr1rrb enabled auto-merge November 26, 2024 21:45

dr1rrb merged commit 419e618 into master Nov 27, 2024
115 checks passed

dr1rrb deleted the dev/xygu/20241125/wasm-pointerdown-over-selection-2 branch November 27, 2024 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(wasm): unwanted preview shown when dragging over existing selection #18921

fix(wasm): unwanted preview shown when dragging over existing selection #18921

Xiaoy312 commented Nov 25, 2024 •

edited

Loading

Xiaoy312 commented Nov 25, 2024 •

edited

Loading

This comment was marked as outdated.

unodevops commented Nov 26, 2024

unodevops commented Nov 26, 2024

unodevops commented Nov 26, 2024

unodevops commented Nov 26, 2024

dr1rrb commented Nov 26, 2024 •

edited

Loading

unodevops commented Nov 26, 2024

unodevops commented Nov 26, 2024

unodevops commented Nov 26, 2024

unodevops commented Nov 27, 2024

nventive-devops commented Nov 27, 2024

unodevops commented Nov 27, 2024

fix(wasm): unwanted preview shown when dragging over existing selection #18921

fix(wasm): unwanted preview shown when dragging over existing selection #18921

Conversation

Xiaoy312 commented Nov 25, 2024 • edited Loading

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

Xiaoy312 commented Nov 25, 2024 • edited Loading

This comment was marked as outdated.

unodevops commented Nov 26, 2024

unodevops commented Nov 26, 2024

unodevops commented Nov 26, 2024

unodevops commented Nov 26, 2024

dr1rrb commented Nov 26, 2024 • edited Loading

unodevops commented Nov 26, 2024

unodevops commented Nov 26, 2024

unodevops commented Nov 26, 2024

unodevops commented Nov 27, 2024

nventive-devops commented Nov 27, 2024

unodevops commented Nov 27, 2024

Xiaoy312 commented Nov 25, 2024 •

edited

Loading

Xiaoy312 commented Nov 25, 2024 •

edited

Loading

dr1rrb commented Nov 26, 2024 •

edited

Loading